You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Justin Erenkrantz <ju...@erenkrantz.com> on 2006/10/30 17:32:20 UTC

Re: svn commit: r469156 - /apr/apr-iconv/branches/STATIC_MODULES/

On 10/30/06, mturk@apache.org <mt...@apache.org> wrote:
> Author: mturk
> Date: Mon Oct 30 06:59:28 2006
> New Revision: 469156
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=469156
> Log:
> Create experimental branch for static (compiled-in) modules support.

What is this?

Ideas need to be discussed on-list first and not just thrown into our
repository.  -- justin

Re: svn commit: r469156 - /apr/apr-iconv/branches/STATIC_MODULES/

Posted by Mladen Turk <mt...@apache.org>.
Justin Erenkrantz wrote:
> On 10/30/06, Mladen Turk <mt...@apache.org> wrote:
>> I was not aware I made any mistake. IMHO, what I did is less
>> harmless then C-T-R/revert.
>> Or do you think I need to ask "someone" before every commit?
> 
> No, but when you create a branch, you should send an email explaining
> what you intend to do with the branch - preferably before you start.

Like said (for the third time) my bad, sorry ;)

> We're not mind readers, ya know.
> 

I'll make some overview by tomorrow for discussion.

In general, it's the same apr-iconv with the option
to have a list of ccs/ces modules you wish to have
built in, at build time.
It has few .awk scripts for patching the ccs/ces
source files (so the changes are at build time), and the
final product can be 2MB libapriconv instead of
3MB libpapriconv + iconv/*.so, and 1 file compared
with 210+ files.
Of course any combination of built in and dynamic
modules is allowed, and apr_iconv_open will first
look for built in modules, and then fall back to .so
module loading.

Regards,
Mladen.

Re: svn commit: r469156 - /apr/apr-iconv/branches/STATIC_MODULES/

Posted by Mladen Turk <mt...@apache.org>.
Justin Erenkrantz wrote:
> On 10/30/06, Mladen Turk <mt...@apache.org> wrote:
>> I was not aware I made any mistake. IMHO, what I did is less
>> harmless then C-T-R/revert.
>> Or do you think I need to ask "someone" before every commit?
> 
> No, but when you create a branch, you should send an email explaining
> what you intend to do with the branch - preferably before you start.

Like said (for the third time) my bad, sorry ;)

> We're not mind readers, ya know.
> 

I'll make some overview by tomorrow for discussion.

In general, it's the same apr-iconv with the option
to have a list of ccs/ces modules you wish to have
built in, at build time.
It has few .awk scripts for patching the ccs/ces
source files (so the changes are at build time), and the
final product can be 2MB libapriconv instead of
3MB libpapriconv + iconv/*.so, and 1 file compared
with 210+ files.
Of course any combination of built in and dynamic
modules is allowed, and apr_iconv_open will first
look for built in modules, and then fall back to .so
module loading.

Regards,
Mladen.

Re: svn commit: r469156 - /apr/apr-iconv/branches/STATIC_MODULES/

Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
On 10/30/06, Mladen Turk <mt...@apache.org> wrote:
> I was not aware I made any mistake. IMHO, what I did is less
> harmless then C-T-R/revert.
> Or do you think I need to ask "someone" before every commit?

No, but when you create a branch, you should send an email explaining
what you intend to do with the branch - preferably before you start.
We're not mind readers, ya know.  -- justin

Re: svn commit: r469156 - /apr/apr-iconv/branches/STATIC_MODULES/

Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
On 10/30/06, Mladen Turk <mt...@apache.org> wrote:
> I was not aware I made any mistake. IMHO, what I did is less
> harmless then C-T-R/revert.
> Or do you think I need to ask "someone" before every commit?

No, but when you create a branch, you should send an email explaining
what you intend to do with the branch - preferably before you start.
We're not mind readers, ya know.  -- justin

Re: svn commit: r469156 - /apr/apr-iconv/branches/STATIC_MODULES/

Posted by Mladen Turk <mt...@apache.org>.
Justin Erenkrantz wrote:
>>
>> Right. I was following the: 'branches are cheap and can be easily 
>> deleted'.
>> Not jet totally finished, so I'll open a discussion when done.
>> If it doesn't attract any interest, I'll just delete it.
> 
> I don't know what the policy is where you come from, but around these
> parts,

I'm the member of this parts just like you. So chill out.

> if you go and create branches, you should discuss the concept
> and the goals of the branch on-list first.
> 

I was not aware I made any mistake. IMHO, what I did is less
harmless then C-T-R/revert.
Or do you think I need to ask "someone" before every commit?

Regards,
Mladen.

Re: svn commit: r469156 - /apr/apr-iconv/branches/STATIC_MODULES/

Posted by Mladen Turk <mt...@apache.org>.
Justin Erenkrantz wrote:
>>
>> Right. I was following the: 'branches are cheap and can be easily 
>> deleted'.
>> Not jet totally finished, so I'll open a discussion when done.
>> If it doesn't attract any interest, I'll just delete it.
> 
> I don't know what the policy is where you come from, but around these
> parts,

I'm the member of this parts just like you. So chill out.

> if you go and create branches, you should discuss the concept
> and the goals of the branch on-list first.
> 

I was not aware I made any mistake. IMHO, what I did is less
harmless then C-T-R/revert.
Or do you think I need to ask "someone" before every commit?

Regards,
Mladen.

Re: svn commit: r469156 - /apr/apr-iconv/branches/STATIC_MODULES/

Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
On 10/30/06, Mladen Turk <mt...@apache.org> wrote:
> Simple code allowing to have some or all ccs/ces modules built in,
> lowering down the amount of generated binaries and size.
>
>  > Ideas need to be discussed on-list first and not just thrown into our
>  > repository.
>
> Right. I was following the: 'branches are cheap and can be easily deleted'.
> Not jet totally finished, so I'll open a discussion when done.
> If it doesn't attract any interest, I'll just delete it.

I don't know what the policy is where you come from, but around these
parts, if you go and create branches, you should discuss the concept
and the goals of the branch on-list first.  -- justin

Re: svn commit: r469156 - /apr/apr-iconv/branches/STATIC_MODULES/

Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
On 10/30/06, Mladen Turk <mt...@apache.org> wrote:
> Simple code allowing to have some or all ccs/ces modules built in,
> lowering down the amount of generated binaries and size.
>
>  > Ideas need to be discussed on-list first and not just thrown into our
>  > repository.
>
> Right. I was following the: 'branches are cheap and can be easily deleted'.
> Not jet totally finished, so I'll open a discussion when done.
> If it doesn't attract any interest, I'll just delete it.

I don't know what the policy is where you come from, but around these
parts, if you go and create branches, you should discuss the concept
and the goals of the branch on-list first.  -- justin

Re: svn commit: r469156 - /apr/apr-iconv/branches/STATIC_MODULES/

Posted by Mladen Turk <mt...@apache.org>.
Justin Erenkrantz wrote:
 >> Create experimental branch for static (compiled-in) modules support.
 >
 > What is this?
 >

Simple code allowing to have some or all ccs/ces modules built in,
lowering down the amount of generated binaries and size.

 > Ideas need to be discussed on-list first and not just thrown into our
 > repository.

Right. I was following the: 'branches are cheap and can be easily deleted'.
Not jet totally finished, so I'll open a discussion when done.
If it doesn't attract any interest, I'll just delete it.

Regards,
Mladen.


Re: svn commit: r469156 - /apr/apr-iconv/branches/STATIC_MODULES/

Posted by Mladen Turk <mt...@apache.org>.
Justin Erenkrantz wrote:
 >> Create experimental branch for static (compiled-in) modules support.
 >
 > What is this?
 >

Simple code allowing to have some or all ccs/ces modules built in,
lowering down the amount of generated binaries and size.

 > Ideas need to be discussed on-list first and not just thrown into our
 > repository.

Right. I was following the: 'branches are cheap and can be easily deleted'.
Not jet totally finished, so I'll open a discussion when done.
If it doesn't attract any interest, I'll just delete it.

Regards,
Mladen.