[GitHub] [activemq-artemis] ViliusS commented on pull request #4307: ARTEMIS-3042 Add docker multistage build

["ViliusS (via GitHub)" <gi...@apache.org>]

ViliusS commented on PR #4307:
URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1524116640

   I'm sorry, but I think this is a step back for CI workflows.
   
   Previously what you had to do to integrate Artemis docker builds into CI pipeline is just download provided Docker file + prepare/run.sh files in the pipeline from Artemis repository and run a few commands. This allowed us to add custom configuration or additional files to docker image itself. Now the preparation step is "hidden" inside docker file. So in order to customize the image we will need to customize provided Docker file which destroys the purpose of that file all together.
   
   Multistage docker builds are great for building the the software from source _for final deployment_, but they are not so great  for processes which require customization.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org