You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/03/11 21:43:11 UTC
[GitHub] [netbeans] philippefichet opened a new pull request #3767: Fix maven daemon detection on windows platform
philippefichet opened a new pull request #3767:
URL: https://github.com/apache/netbeans/pull/3767
In the "bin" folder of "mvnd-0.7.1-windows-amd64" (latest current release), the list of files is as follows:
```
├── mvnd-bash-completion.bash
├── mvnd-sync.exe
├── mvnd.cmd
├── mvnd.exe
└── mvnd.sh
```
I take the liberty of adding the suffix ".cmd" when detecting under windows only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #3767: Fix maven daemon detection on windows platform
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3767:
URL: https://github.com/apache/netbeans/pull/3767#issuecomment-1068436429
After 4 tries, travis is also happy. Lets get this in. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3767: Fix maven daemon detection on windows platform
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3767:
URL: https://github.com/apache/netbeans/pull/3767#discussion_r825220721
##########
File path: java/maven/src/org/netbeans/modules/maven/execute/cmd/ShellConstructor.java
##########
@@ -44,7 +44,9 @@ public ShellConstructor(@NonNull File mavenHome) {
public List<String> construct() {
// use mvnd if its the home of a daemon
- String ex = Files.exists(Paths.get(mavenHome.getPath(), "bin", "mvnd")) ? "mvnd" : "mvn"; //NOI18N
+ String mavenDaemonSuffixDetection = Utilities.isWindows() ? ".cmd" : "";
+ String ex = Files.exists(Paths.get(mavenHome.getPath(), "bin", "mvnd" + mavenDaemonSuffixDetection)) ? "mvnd" : "mvn"; //NOI18N
Review comment:
i think we should probe here for `mvnd.exe` instead of `.cmd` because `mvnd` is a binary. It is not super important but it would make it symmetrical.
Thanks for fixing this for windows btw. Feel free to force push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] philippefichet commented on a change in pull request #3767: Fix maven daemon detection on windows platform
Posted by GitBox <gi...@apache.org>.
philippefichet commented on a change in pull request #3767:
URL: https://github.com/apache/netbeans/pull/3767#discussion_r825303375
##########
File path: java/maven/src/org/netbeans/modules/maven/execute/cmd/ShellConstructor.java
##########
@@ -44,7 +44,9 @@ public ShellConstructor(@NonNull File mavenHome) {
public List<String> construct() {
// use mvnd if its the home of a daemon
- String ex = Files.exists(Paths.get(mavenHome.getPath(), "bin", "mvnd")) ? "mvnd" : "mvn"; //NOI18N
+ String mavenDaemonSuffixDetection = Utilities.isWindows() ? ".cmd" : "";
+ String ex = Files.exists(Paths.get(mavenHome.getPath(), "bin", "mvnd" + mavenDaemonSuffixDetection)) ? "mvnd" : "mvn"; //NOI18N
Review comment:
Change done :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] philippefichet commented on pull request #3767: Fix maven daemon detection on windows platform
Posted by GitBox <gi...@apache.org>.
philippefichet commented on pull request #3767:
URL: https://github.com/apache/netbeans/pull/3767#issuecomment-1068121127
@matthiasblaesing squash is done ;) (sorry for the delay)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #3767: Fix maven daemon detection on windows platform
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3767:
URL: https://github.com/apache/netbeans/pull/3767#issuecomment-1065944767
Ah - minimal nitpick: @philippefichet could you please squash the two commits into one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #3767: Fix maven daemon detection on windows platform
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #3767:
URL: https://github.com/apache/netbeans/pull/3767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #3767: Fix maven daemon detection on windows platform
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3767:
URL: https://github.com/apache/netbeans/pull/3767#issuecomment-1065944629
Looks also sane to me. Lets get this in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists