You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/10 07:22:27 UTC
[GitHub] [airflow] dewaldabrie opened a new pull request #10272: Update base classes used in bigquery_check_operator to renamed versions
dewaldabrie opened a new pull request #10272:
URL: https://github.com/apache/airflow/pull/10272
`airflow.contrib.operators.bigquery_check_operator.BigQueryValueCheckOperator` [is derived from](https://github.com/apache/airflow/blob/69cc8370e486e00dd526e96c2b0aacd348ee255e/airflow/contrib/operators/bigquery_check_operator.py#L82) `airflow.operators.check_operator.ValueCheckOperator` but needs to be derived from `airflow.operators.sql.SQLValueCheckOperator` instead.
Until this is done, airflow generates a lot of warnings from [this](https://github.com/apache/airflow/blob/69cc8370e486e00dd526e96c2b0aacd348ee255e/airflow/operators/check_operator.py#L81) line of code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #10272: Update base classes used in bigquery_check_operator to renamed versions
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #10272:
URL: https://github.com/apache/airflow/pull/10272#issuecomment-671668623
@dewaldabrie Can you look here? https://github.com/apache/airflow/issues/10271
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dewaldabrie commented on pull request #10272: Update base classes used in bigquery_check_operator to renamed versions
Posted by GitBox <gi...@apache.org>.
dewaldabrie commented on pull request #10272:
URL: https://github.com/apache/airflow/pull/10272#issuecomment-672593824
@mik-laj Thanks, I replied there. Not sure why the checks in the CI is failing since it seems related to things I didn't touch like `Add license for all SQL files`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10272: Update base classes used in bigquery_check_operator to renamed versions
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10272:
URL: https://github.com/apache/airflow/pull/10272#issuecomment-672795760
SHould be fixed now by https://github.com/apache/airflow/pull/10299. I also cherry-picked it to 1-10-stable and 1-10-test. Can you please rebase again on top of the latest v1-10-stable and it should be fixed permanently now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10272: Update base classes used in bigquery_check_operator to renamed versions
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10272:
URL: https://github.com/apache/airflow/pull/10272#issuecomment-674229448
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10272: Update base classes used in bigquery_check_operator to renamed versions
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10272:
URL: https://github.com/apache/airflow/pull/10272#issuecomment-672787766
We have a bug in the CI cache specification. I am going to fix it shortly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10272: Update base classes used in bigquery_check_operator to renamed versions
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10272:
URL: https://github.com/apache/airflow/pull/10272#issuecomment-671202146
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #10272: Update base classes used in bigquery_check_operator to renamed versions
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #10272:
URL: https://github.com/apache/airflow/pull/10272
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10272: Update base classes used in bigquery_check_operator to renamed versions
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10272:
URL: https://github.com/apache/airflow/pull/10272#issuecomment-673687133
Hey @dewaldabrie - if you want this one to be part of 1.10.12 (willl be released very shortly) you should rebase this one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org