You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "davsclaus (via GitHub)" <gi...@apache.org> on 2026/06/02 20:15:02 UTC

[PR] CAMEL-23662: camel-log - Route logMask setting not overriding context logMask [camel]

davsclaus opened a new pull request, #23715:
URL: https://github.com/apache/camel/pull/23715

   ## Summary
   
   Fixes [CAMEL-23662](https://issues.apache.org/jira/browse/CAMEL-23662): Setting `logMask="false"` on a route did not override `logMask="true"` on the CamelContext when using the log **component** (`<to uri="log:..."/>`). The override only worked with the Log **EIP** (`.log("...")`) or as a query parameter on the endpoint URI (`?logMask=false`).
   
   ## Root Cause
   
   `LogEndpoint.getMaskingFormatter()` resolved the masking decision at endpoint creation time, consulting only the endpoint's URI parameter and `CamelContext.isLogMask()`. It never checked the route's `logMask` setting. The Log EIP (`LogReifier`) correctly consulted `route.isLogMask()` at reification time, but the Log component endpoint did not.
   
   ## Fix
   
   - `CamelLogProcessor` now supports checking the route's `logMask` at process time via `exchange.getUnitOfWork().getRoute()`, respecting the precedence: **endpoint parameter > route > context**
   - `LogEndpoint` enables this route-aware behavior when creating the `CamelLogProcessor`
   - This also fixes the inverse case (route enables masking while context has it disabled)
   
   ## Test Plan
   
   - [x] New test `LogMaskRouteOverrideTest` verifying:
     - Route `logMask=false` overrides context `logMask=true` for the log component
     - Route `logMask=true` overrides context `logMask=false` for the log component
   - [x] Existing `LogMaskTest` and `LogEipMaskTest` still pass (no regressions)
   - [x] Full reactor build passes
   
   _Claude Code on behalf of Claus Ibsen_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23662: camel-log - Route logMask setting not overriding context logMask [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23715:
URL: https://github.com/apache/camel/pull/23715#issuecomment-4606819285

   :star2: Thank you for your contribution to the Apache Camel project! :star2:
     :robot: CI automation will test this PR automatically.
   
     :camel: Apache Camel Committers, please review the following items:
   
     * First-time contributors **require MANUAL approval** for the GitHub Actions to run
     * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
     * You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
     * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
     
     :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23662: camel-log - Route logMask setting not overriding context logMask [camel]

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #23715:
URL: https://github.com/apache/camel/pull/23715


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23662: camel-log - Route logMask setting not overriding context logMask [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23715:
URL: https://github.com/apache/camel/pull/23715#issuecomment-4606973128

   <!-- ci-tested-modules -->
   :test_tube: **CI tested the following changed modules:**
   
   - `components/camel-log`
   - `core/camel-core`
   - `core/camel-support`
   
   > :information_source: Dependent modules were not tested because the total number of affected modules exceeded the threshold (50). Use the `test-dependents` label to force testing all dependents.
   
   :warning: **Some tests are disabled on GitHub Actions** (`@DisabledIfSystemProperty(named = "ci.env.name")`) and require manual verification:
   
   - `core/camel-core`: 2 test(s) disabled on GitHub Actions
   
   <details><summary>Build reactor — dependencies compiled but only changed modules were tested (3 modules)</summary>
   
   - Camel :: Core
   - Camel :: Log
   - Camel :: Support
   
   </details>
   
   ---
   :gear: [View full build and test results](https://github.com/apache/camel/actions/runs/26845416498)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org