You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/09/24 17:22:01 UTC
[jira] [Commented] (FLINK-7577) flink-core
[ https://issues.apache.org/jira/browse/FLINK-7577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178283#comment-16178283 ]
ASF GitHub Bot commented on FLINK-7577:
---------------------------------------
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/4714
[FLINK-7577][build] POM Cleanup flink-core
## What is the purpose of the change
This PR changes the flink-core pom to
- not contain unused dependencies
- contain all used dependencies
## Brief change log
## Verifying this change
_mvn dependency:analyze_
```
[INFO] --- maven-dependency-plugin:2.10:analyze (default-cli) @ flink-core ---
[WARNING] Used undeclared dependencies found:
[WARNING] org.hamcrest:hamcrest-core:jar:1.3:test
[WARNING] org.powermock:powermock-core:jar:1.6.5:test
[WARNING] org.powermock:powermock-reflect:jar:1.6.5:test
[WARNING] org.objenesis:objenesis:jar:2.1:compile
[WARNING] Unused declared dependencies found:
[WARNING] org.xerial.snappy:snappy-java:jar:1.1.1.3:compile
[WARNING] org.hamcrest:hamcrest-all:jar:1.3:test
[WARNING] org.apache.flink:force-shading:jar:1.4-SNAPSHOT:compile
[WARNING] log4j:log4j:jar:1.2.17:test
[WARNING] org.joda:joda-convert:jar:1.7:test
[WARNING] org.slf4j:slf4j-log4j12:jar:1.7.7:test
```
After the change:
```
[INFO] --- maven-dependency-plugin:2.10:analyze (default-cli) @ flink-core ---
[WARNING] Used undeclared dependencies found:
[WARNING] org.hamcrest:hamcrest-core:jar:1.3:test
[WARNING] org.powermock:powermock-core:jar:1.6.5:test
[WARNING] org.powermock:powermock-reflect:jar:1.6.5:test
[WARNING] org.objenesis:objenesis:jar:2.1:compile
[WARNING] Unused declared dependencies found:
[WARNING] org.xerial.snappy:snappy-java:jar:1.1.1.3:compile
[WARNING] org.hamcrest:hamcrest-all:jar:1.3:test
[WARNING] org.apache.flink:force-shading:jar:1.4-SNAPSHOT:compile
[WARNING] log4j:log4j:jar:1.2.17:test
[WARNING] org.slf4j:slf4j-log4j12:jar:1.7.7:test
```
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes)
## Documentation
none
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yew1eb/flink FLINK-7577
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4714.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4714
----
commit 7ede14db9f96185c064535c77602c6230bd3e080
Author: yew1eb <ye...@gmail.com>
Date: 2017-09-04T15:30:58Z
fix flink-core undeclared/unused dependencies
----
> flink-core
> ----------
>
> Key: FLINK-7577
> URL: https://issues.apache.org/jira/browse/FLINK-7577
> Project: Flink
> Issue Type: Sub-task
> Components: Build System
> Environment: Apache Maven 3.3.9, Java version: 1.8.0_144
> Reporter: Hai Zhou_UTC+8
> Assignee: Hai Zhou_UTC+8
>
> {noformat}
> [INFO] --- maven-dependency-plugin:2.10:analyze (default-cli) @ flink-core ---
> [WARNING] Used undeclared dependencies found:
> [WARNING] org.hamcrest:hamcrest-core:jar:1.3:test
> [WARNING] org.powermock:powermock-core:jar:1.6.5:test
> [WARNING] org.powermock:powermock-reflect:jar:1.6.5:test
> [WARNING] org.objenesis:objenesis:jar:2.1:compile
> [WARNING] Unused declared dependencies found:
> [WARNING] org.xerial.snappy:snappy-java:jar:1.1.1.3:compile
> [WARNING] org.hamcrest:hamcrest-all:jar:1.3:test
> [WARNING] org.apache.flink:force-shading:jar:1.4-SNAPSHOT:compile
> [WARNING] log4j:log4j:jar:1.2.17:test
> [WARNING] org.joda:joda-convert:jar:1.7:test
> [WARNING] org.slf4j:slf4j-log4j12:jar:1.7.7:test
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)