You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2023/01/04 02:33:58 UTC

[GitHub] [rocketmq-clients] aaron-ai commented on a diff in pull request #235: feat: Make each 'Client' have an independent 'ClientManager'

aaron-ai commented on code in PR #235:
URL: https://github.com/apache/rocketmq-clients/pull/235#discussion_r1059641303


##########
golang/client_manager.go:
##########
@@ -90,13 +90,14 @@ type ClientManagerRegistry interface {
 }
 
 type clientManagerRegistry struct {

Review Comment:
   Could we remove `clientManagerRegistry`, since each `client` has its own `clientManager`, there is no need to maintain a "registry".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org