You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/01/21 23:13:00 UTC
[jira] [Commented] (ISIS-1628) MixinFacet doesn't properly create
domain events if abstract and invoke via the wrapper (ie during integ
tests)
[ https://issues.apache.org/jira/browse/ISIS-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269691#comment-17269691 ]
ASF subversion and git services commented on ISIS-1628:
-------------------------------------------------------
Commit 01b627e8085cf8a29aa4ace57056886cb7c91a8b in isis's branch refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=01b627e ]
ISIS-1628: no longer requires method to be overridden in mixin subclass.
> MixinFacet doesn't properly create domain events if abstract and invoke via the wrapper (ie during integ tests)
> ---------------------------------------------------------------------------------------------------------------
>
> Key: ISIS-1628
> URL: https://issues.apache.org/jira/browse/ISIS-1628
> Project: Isis
> Issue Type: Improvement
> Components: Isis Core
> Affects Versions: 1.14.0
> Reporter: Daniel Keir Haywood
> Priority: Minor
>
> fix, don't use getDeclaredFields, instead getFields (I think... to test)
> ~~~
> because of https://github.com/apache/isis/blob/69b4859f27ce857e9af75b7d1ef0ae7b42e5cc2c/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/mixin/MixinFacetAbstract.java#L97
> getDeclaredFields() rather than getFields()
> to reproduce, eg HasDocumentAbstract_categoriseAbstract subclasses.
> ~~~~
> Also, necessary to override the method itself in the subclass, else
> https://github.com/apache/isis/blob/69b4859f27ce857e9af75b7d1ef0ae7b42e5cc2c/core/wrapper/src/main/java/org/apache/isis/core/wrapper/handlers/DomainObjectInvocationHandler.java#L297
> does not find the actual ObjectActionMixedIn (the mixin's ObjectActionDefault does not match)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)