[GitHub] sijie commented on issue #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set

[GitBox <gi...@apache.org>]

sijie commented on issue #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set
URL: https://github.com/apache/pulsar/pull/3126#issuecomment-445046604
 
 
   > My concern was the following case while messageRoutingMode is not set by user and it comes as RoundRobinPartition as default through 
   
   I think the right fix here is: 
   
   - in the builder, set the default `messageRoutingMode` to be null.
   - in the `build()` method:
     * if both `messageRoutingMode` and `messageRouter` are null, use `RoundRobin`
     * if `messageRouter` is set, `messageRoutingMode` should be `CustomRobin`
     * in `setMessageRouter` method, `messageRouter` should be null. if not, fail it immediately. if it is null, set `messageRoutingMode` to custom
     * in `setMessageRoutingMode`, if messageRouter is not null, it only accepts `Custom`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services