[GitHub] [superset] corbinrobb commented on pull request #22093: test(sqllab): Convert tests to RTL for SqlEditor

[GitBox <gi...@apache.org>]

corbinrobb commented on PR #22093:
URL: https://github.com/apache/superset/pull/22093#issuecomment-1310875502

   Hey! @EugeneTorap Thank you and thanks for the review!
   
   I would like to remove the `mount` import on line 20 and also the `buildWrapper` function on line 120 but they are still being used inside of the two skipped tests lines 235 - 260. I am not sure what is going one with those two or whether we want to keep them or not.
   
   I notice there is a comment by @eschutho to convert them to RTL. What do you all think? Should I try to convert those two, delete them, or leave them alone?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org