[skywalking] branch master updated: Add counters for metrics reading from DB or cached. (#10025)

[wu...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git


The following commit(s) were added to refs/heads/master by this push:
     new 5df7bebd38 Add counters for metrics reading from DB or cached. (#10025)
5df7bebd38 is described below

commit 5df7bebd38d5fd243627c147c758316d7fa075ab
Author: 吴晟 Wu Sheng <wu...@foxmail.com>
AuthorDate: Fri Nov 25 10:43:07 2022 +0800

    Add counters for metrics reading from DB or cached. (#10025)
---
 .../analysis/worker/MetricsPersistentWorker.java   | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java
index 5cf248ace4..8ab2e69777 100644
--- a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java
+++ b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java
@@ -80,7 +80,18 @@ public class MetricsPersistentWorker extends PersistenceWorker<Metrics> {
     private final Optional<MetricsTransWorker> transWorker;
     private final boolean supportUpdate;
     private long sessionTimeout;
+    /**
+     * The counter of L2 aggregation.
+     */
     private CounterMetrics aggregationCounter;
+    /**
+     * The counter of metrics reading from Database.
+     */
+    private CounterMetrics readMetricsCounter;
+    /**
+     * The counter of metrics cached in-memory.
+     */
+    private CounterMetrics cachedMetricsCounter;
     /**
      * The counter for the round of persistent.
      */
@@ -147,6 +158,14 @@ public class MetricsPersistentWorker extends PersistenceWorker<Metrics> {
             new MetricsTag.Keys("metricName", "level", "dimensionality"),
             new MetricsTag.Values(model.getName(), "2", model.getDownsampling().getName())
         );
+        readMetricsCounter = metricsCreator.createCounter(
+            "metrics_persistent_cache", "The counter of metrics status, new or cached.",
+            new MetricsTag.Keys("status"), new MetricsTag.Values("new")
+        );
+        cachedMetricsCounter = metricsCreator.createCounter(
+            "metrics_persistent_cache", "The counter of metrics status, new or cached.",
+            new MetricsTag.Keys("status"), new MetricsTag.Values("cached")
+        );
         SESSION_TIMEOUT_OFFSITE_COUNTER++;
     }
 
@@ -325,6 +344,9 @@ public class MetricsPersistentWorker extends PersistenceWorker<Metrics> {
                            return false;
                        })
                        .collect(Collectors.toList());
+
+            readMetricsCounter.inc(notInCacheMetrics.size());
+            cachedMetricsCounter.inc(metrics.size() - notInCacheMetrics.size());
             if (notInCacheMetrics.isEmpty()) {
                 return;
             }