You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/12 20:38:43 UTC
[GitHub] [superset] betodealmeida opened a new pull request #12472: fix (SQL Lab): disappearing results on tab switch
betodealmeida opened a new pull request #12472:
URL: https://github.com/apache/superset/pull/12472
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
When switching away from a SQL tab with results and back again, the results don't show up because the height of the component is computed incorrectly.
I fixed it by simply reusing the height passed as props.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
How to repro:
1. Go to SQL Lab and run a query with results
2. Switch to another tab
3. Switch back
4. No results are displayed
With this PR, it works as expected:
https://user-images.githubusercontent.com/1534870/104369922-fed26a00-54d2-11eb-8a67-078f0bc377a1.mov
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
See above.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12472:
URL: https://github.com/apache/superset/pull/12472#issuecomment-759083184
# [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=h1) Report
> Merging [#12472](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=desc) (74acc83) into [master](https://codecov.io/gh/apache/superset/commit/ddbcf5b0e9a3ea7aed4d22e8438d9a75acd26275?el=desc) (ddbcf5b) will **decrease** coverage by `3.17%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12472 +/- ##
==========================================
- Coverage 62.53% 59.36% -3.18%
==========================================
Files 1014 959 -55
Lines 49509 46784 -2725
Branches 5078 4339 -739
==========================================
- Hits 30962 27773 -3189
- Misses 18337 19011 +674
+ Partials 210 0 -210
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <100.00%> (?)` | |
| javascript | `?` | |
| python | `64.08% <ø> (+0.35%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `64.10% <100.00%> (-18.88%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `8.00% <0.00%> (-84.00%)` | :arrow_down: |
| ... and [456 more](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=footer). Last update [ddbcf5b...1907dc2](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12472:
URL: https://github.com/apache/superset/pull/12472#issuecomment-759083184
# [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=h1) Report
> Merging [#12472](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=desc) (62abc19) into [master](https://codecov.io/gh/apache/superset/commit/ddbcf5b0e9a3ea7aed4d22e8438d9a75acd26275?el=desc) (ddbcf5b) will **increase** coverage by `1.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12472 +/- ##
==========================================
+ Coverage 62.53% 63.55% +1.01%
==========================================
Files 1014 486 -528
Lines 49509 29914 -19595
Branches 5078 0 -5078
==========================================
- Hits 30962 19011 -11951
+ Misses 18337 10903 -7434
+ Partials 210 0 -210
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.55% <ø> (-0.18%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.56% <0.00%> (-1.31%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.55%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/css\_templates/api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9hcGkucHk=) | `95.74% <0.00%> (ø)` | |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `83.19% <0.00%> (ø)` | |
| [...-frontend/src/SqlLab/components/HighlightedSql.jsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0hpZ2hsaWdodGVkU3FsLmpzeA==) | | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | | |
| ... and [534 more](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=footer). Last update [ddbcf5b...62abc19](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12472:
URL: https://github.com/apache/superset/pull/12472#issuecomment-759083184
# [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=h1) Report
> Merging [#12472](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=desc) (35b6b3e) into [master](https://codecov.io/gh/apache/superset/commit/ddbcf5b0e9a3ea7aed4d22e8438d9a75acd26275?el=desc) (ddbcf5b) will **increase** coverage by `1.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12472 +/- ##
==========================================
+ Coverage 62.53% 63.55% +1.01%
==========================================
Files 1014 486 -528
Lines 49509 29921 -19588
Branches 5078 0 -5078
==========================================
- Hits 30962 19017 -11945
+ Misses 18337 10904 -7433
+ Partials 210 0 -210
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.55% <ø> (-0.18%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.56% <0.00%> (-1.31%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.55%)` | :arrow_down: |
| [superset/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `86.04% <0.00%> (-0.07%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/css\_templates/api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9hcGkucHk=) | `95.74% <0.00%> (ø)` | |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `83.19% <0.00%> (ø)` | |
| [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `55.55% <0.00%> (ø)` | |
| ... and [536 more](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=footer). Last update [ddbcf5b...35b6b3e](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12472:
URL: https://github.com/apache/superset/pull/12472#issuecomment-759083184
# [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=h1) Report
> Merging [#12472](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=desc) (35b6b3e) into [master](https://codecov.io/gh/apache/superset/commit/ddbcf5b0e9a3ea7aed4d22e8438d9a75acd26275?el=desc) (ddbcf5b) will **increase** coverage by `0.65%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12472 +/- ##
==========================================
+ Coverage 62.53% 63.19% +0.65%
==========================================
Files 1014 486 -528
Lines 49509 29906 -19603
Branches 5078 0 -5078
==========================================
- Hits 30962 18899 -12063
+ Misses 18337 11007 -7330
+ Partials 210 0 -210
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.19% <ø> (-0.54%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `86.55% <0.00%> (-5.43%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `95.60% <0.00%> (-4.40%)` | :arrow_down: |
| ... and [559 more](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=footer). Last update [ddbcf5b...35b6b3e](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #12472:
URL: https://github.com/apache/superset/pull/12472#discussion_r556168899
##########
File path: superset-frontend/src/SqlLab/components/SouthPane.jsx
##########
@@ -90,20 +90,11 @@ export class SouthPane extends React.PureComponent {
height: props.height,
};
this.southPaneRef = React.createRef();
- this.getSouthPaneHeight = this.getSouthPaneHeight.bind(this);
this.switchTab = this.switchTab.bind(this);
}
- UNSAFE_componentWillReceiveProps() {
- // south pane expands the entire height of the tab content on mount
- this.setState({ height: this.getSouthPaneHeight() });
- }
-
- // One layer of abstraction for easy spying in unit tests
- getSouthPaneHeight() {
- return this.southPaneRef.current
- ? this.southPaneRef.current.clientHeight
- : 0;
+ UNSAFE_componentWillReceiveProps(props) {
+ this.setState({ height: props.height });
Review comment:
since state is just a representation of props at this point, can we remove the state and just use the props?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12472:
URL: https://github.com/apache/superset/pull/12472#issuecomment-759083184
# [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=h1) Report
> Merging [#12472](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=desc) (1907dc2) into [master](https://codecov.io/gh/apache/superset/commit/ddbcf5b0e9a3ea7aed4d22e8438d9a75acd26275?el=desc) (ddbcf5b) will **increase** coverage by `1.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12472 +/- ##
==========================================
+ Coverage 62.53% 63.55% +1.01%
==========================================
Files 1014 486 -528
Lines 49509 29921 -19588
Branches 5078 0 -5078
==========================================
- Hits 30962 19017 -11945
+ Misses 18337 10904 -7433
+ Partials 210 0 -210
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.55% <ø> (-0.18%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.56% <0.00%> (-1.31%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.55%)` | :arrow_down: |
| [superset/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `86.04% <0.00%> (-0.07%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/css\_templates/api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9hcGkucHk=) | `95.74% <0.00%> (ø)` | |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `83.19% <0.00%> (ø)` | |
| [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `55.55% <0.00%> (ø)` | |
| ... and [536 more](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=footer). Last update [ddbcf5b...1907dc2](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12472:
URL: https://github.com/apache/superset/pull/12472#issuecomment-759083184
# [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=h1) Report
> Merging [#12472](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=desc) (74acc83) into [master](https://codecov.io/gh/apache/superset/commit/ddbcf5b0e9a3ea7aed4d22e8438d9a75acd26275?el=desc) (ddbcf5b) will **increase** coverage by `1.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12472 +/- ##
==========================================
+ Coverage 62.53% 64.08% +1.55%
==========================================
Files 1014 486 -528
Lines 49509 29921 -19588
Branches 5078 0 -5078
==========================================
- Hits 30962 19176 -11786
+ Misses 18337 10745 -7592
+ Partials 210 0 -210
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `64.08% <ø> (+0.35%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.56% <0.00%> (-1.31%)` | :arrow_down: |
| [superset/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `86.04% <0.00%> (-0.07%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/css\_templates/api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9hcGkucHk=) | `95.74% <0.00%> (ø)` | |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `83.19% <0.00%> (ø)` | |
| [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `55.55% <0.00%> (ø)` | |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | | |
| [...hboard/components/nativeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvQ2FzY2FkZVBvcG92ZXIudHN4) | | |
| [.../src/dashboard/components/UndoRedoKeylisteners.jsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1VuZG9SZWRvS2V5bGlzdGVuZXJzLmpzeA==) | | |
| [...c/visualizations/TimeTable/TimeTableChartPlugin.js](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS9UaW1lVGFibGVDaGFydFBsdWdpbi5qcw==) | | |
| ... and [535 more](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=footer). Last update [ddbcf5b...1907dc2](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12472:
URL: https://github.com/apache/superset/pull/12472#issuecomment-759083184
# [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=h1) Report
> Merging [#12472](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=desc) (1907dc2) into [master](https://codecov.io/gh/apache/superset/commit/ddbcf5b0e9a3ea7aed4d22e8438d9a75acd26275?el=desc) (ddbcf5b) will **increase** coverage by `0.65%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12472 +/- ##
==========================================
+ Coverage 62.53% 63.19% +0.65%
==========================================
Files 1014 486 -528
Lines 49509 29906 -19603
Branches 5078 0 -5078
==========================================
- Hits 30962 18899 -12063
+ Misses 18337 11007 -7330
+ Partials 210 0 -210
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.19% <ø> (-0.54%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `86.55% <0.00%> (-5.43%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `95.60% <0.00%> (-4.40%)` | :arrow_down: |
| ... and [559 more](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=footer). Last update [ddbcf5b...1907dc2](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12472:
URL: https://github.com/apache/superset/pull/12472#issuecomment-759083184
# [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=h1) Report
> Merging [#12472](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=desc) (62abc19) into [master](https://codecov.io/gh/apache/superset/commit/ddbcf5b0e9a3ea7aed4d22e8438d9a75acd26275?el=desc) (ddbcf5b) will **increase** coverage by `1.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12472 +/- ##
==========================================
+ Coverage 62.53% 63.55% +1.01%
==========================================
Files 1014 486 -528
Lines 49509 29914 -19595
Branches 5078 0 -5078
==========================================
- Hits 30962 19011 -11951
+ Misses 18337 10903 -7434
+ Partials 210 0 -210
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.55% <ø> (-0.18%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.56% <0.00%> (-1.31%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.55%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/css\_templates/api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9hcGkucHk=) | `95.74% <0.00%> (ø)` | |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `83.19% <0.00%> (ø)` | |
| [superset-frontend/src/components/AsyncSelect.jsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QuanN4) | | |
| [...frontend/src/dashboard/util/newEntitiesFromDrop.js](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0VudGl0aWVzRnJvbURyb3AuanM=) | | |
| ... and [534 more](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=footer). Last update [ddbcf5b...62abc19](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12472:
URL: https://github.com/apache/superset/pull/12472#issuecomment-759083184
# [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=h1) Report
> Merging [#12472](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=desc) (74acc83) into [master](https://codecov.io/gh/apache/superset/commit/ddbcf5b0e9a3ea7aed4d22e8438d9a75acd26275?el=desc) (ddbcf5b) will **increase** coverage by `1.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12472 +/- ##
==========================================
+ Coverage 62.53% 64.08% +1.55%
==========================================
Files 1014 486 -528
Lines 49509 29921 -19588
Branches 5078 0 -5078
==========================================
- Hits 30962 19176 -11786
+ Misses 18337 10745 -7592
+ Partials 210 0 -210
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `64.08% <ø> (+0.35%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.56% <0.00%> (-1.31%)` | :arrow_down: |
| [superset/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `86.04% <0.00%> (-0.07%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/css\_templates/api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9hcGkucHk=) | `95.74% <0.00%> (ø)` | |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `83.19% <0.00%> (ø)` | |
| [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `55.55% <0.00%> (ø)` | |
| [.../src/dashboard/util/serializeActiveFilterValues.js](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUFjdGl2ZUZpbHRlclZhbHVlcy5qcw==) | | |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | | |
| [...tend/src/explore/components/ExploreChartHeader.jsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIuanN4) | | |
| [...rc/explore/components/controls/TextAreaControl.jsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0QXJlYUNvbnRyb2wuanN4) | | |
| ... and [535 more](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=footer). Last update [ddbcf5b...1907dc2](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12472:
URL: https://github.com/apache/superset/pull/12472#issuecomment-759083184
# [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=h1) Report
> Merging [#12472](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=desc) (62abc19) into [master](https://codecov.io/gh/apache/superset/commit/ddbcf5b0e9a3ea7aed4d22e8438d9a75acd26275?el=desc) (ddbcf5b) will **increase** coverage by `0.98%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12472 +/- ##
==========================================
+ Coverage 62.53% 63.52% +0.98%
==========================================
Files 1014 486 -528
Lines 49509 29899 -19610
Branches 5078 0 -5078
==========================================
- Hits 30962 18992 -11970
+ Misses 18337 10907 -7430
+ Partials 210 0 -210
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.52% <ø> (-0.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `82.45% <0.00%> (-3.51%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.56% <0.00%> (-1.31%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.55%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.68% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/migrations/shared/security\_converge.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvc2VjdXJpdHlfY29udmVyZ2UucHk=) | `86.82% <0.00%> (-0.11%)` | :arrow_down: |
| ... and [544 more](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=footer). Last update [ddbcf5b...62abc19](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12472:
URL: https://github.com/apache/superset/pull/12472#issuecomment-759083184
# [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=h1) Report
> Merging [#12472](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=desc) (74acc83) into [master](https://codecov.io/gh/apache/superset/commit/ddbcf5b0e9a3ea7aed4d22e8438d9a75acd26275?el=desc) (ddbcf5b) will **increase** coverage by `1.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12472 +/- ##
==========================================
+ Coverage 62.53% 63.55% +1.01%
==========================================
Files 1014 486 -528
Lines 49509 29921 -19588
Branches 5078 0 -5078
==========================================
- Hits 30962 19017 -11945
+ Misses 18337 10904 -7433
+ Partials 210 0 -210
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.55% <ø> (-0.18%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.56% <0.00%> (-1.31%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.55%)` | :arrow_down: |
| [superset/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `86.04% <0.00%> (-0.07%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/css\_templates/api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9hcGkucHk=) | `95.74% <0.00%> (ø)` | |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `83.19% <0.00%> (ø)` | |
| [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `55.55% <0.00%> (ø)` | |
| ... and [536 more](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=footer). Last update [ddbcf5b...74acc83](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12472:
URL: https://github.com/apache/superset/pull/12472#issuecomment-759083184
# [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=h1) Report
> Merging [#12472](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=desc) (74acc83) into [master](https://codecov.io/gh/apache/superset/commit/ddbcf5b0e9a3ea7aed4d22e8438d9a75acd26275?el=desc) (ddbcf5b) will **increase** coverage by `1.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12472 +/- ##
==========================================
+ Coverage 62.53% 64.08% +1.55%
==========================================
Files 1014 486 -528
Lines 49509 29921 -19588
Branches 5078 0 -5078
==========================================
- Hits 30962 19176 -11786
+ Misses 18337 10745 -7592
+ Partials 210 0 -210
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `64.08% <ø> (+0.35%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.56% <0.00%> (-1.31%)` | :arrow_down: |
| [superset/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `86.04% <0.00%> (-0.07%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/css\_templates/api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9hcGkucHk=) | `95.74% <0.00%> (ø)` | |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `83.19% <0.00%> (ø)` | |
| [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `55.55% <0.00%> (ø)` | |
| [superset-frontend/src/components/AsyncSelect.jsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QuanN4) | | |
| [...frontend/src/dashboard/util/newEntitiesFromDrop.js](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0VudGl0aWVzRnJvbURyb3AuanM=) | | |
| [...tend/src/dashboard/components/DashboardBuilder.jsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | | |
| [superset-frontend/src/logger/actions/index.ts](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2xvZ2dlci9hY3Rpb25zL2luZGV4LnRz) | | |
| ... and [535 more](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=footer). Last update [ddbcf5b...1907dc2](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak commented on pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12472:
URL: https://github.com/apache/superset/pull/12472#issuecomment-759462917
Tested manually - works fine
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #12472:
URL: https://github.com/apache/superset/pull/12472#issuecomment-759590625
Merging for inclusion in 1.0.0rc2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12472:
URL: https://github.com/apache/superset/pull/12472#issuecomment-759083184
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12472:
URL: https://github.com/apache/superset/pull/12472#issuecomment-759083184
# [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=h1) Report
> Merging [#12472](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=desc) (62abc19) into [master](https://codecov.io/gh/apache/superset/commit/ddbcf5b0e9a3ea7aed4d22e8438d9a75acd26275?el=desc) (ddbcf5b) will **increase** coverage by `0.93%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12472 +/- ##
==========================================
+ Coverage 62.53% 63.47% +0.93%
==========================================
Files 1014 486 -528
Lines 49509 29899 -19610
Branches 5078 0 -5078
==========================================
- Hits 30962 18977 -11985
+ Misses 18337 10922 -7415
+ Partials 210 0 -210
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.47% <ø> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `82.45% <0.00%> (-3.51%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.56% <0.00%> (-1.31%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.65% <0.00%> (-0.93%)` | :arrow_down: |
| ... and [548 more](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=footer). Last update [ddbcf5b...62abc19](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12472:
URL: https://github.com/apache/superset/pull/12472#issuecomment-759083184
# [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=h1) Report
> Merging [#12472](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=desc) (74acc83) into [master](https://codecov.io/gh/apache/superset/commit/ddbcf5b0e9a3ea7aed4d22e8438d9a75acd26275?el=desc) (ddbcf5b) will **increase** coverage by `1.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12472 +/- ##
==========================================
+ Coverage 62.53% 64.08% +1.55%
==========================================
Files 1014 486 -528
Lines 49509 29921 -19588
Branches 5078 0 -5078
==========================================
- Hits 30962 19176 -11786
+ Misses 18337 10745 -7592
+ Partials 210 0 -210
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `64.08% <ø> (+0.35%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.56% <0.00%> (-1.31%)` | :arrow_down: |
| [superset/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `86.04% <0.00%> (-0.07%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/css\_templates/api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9hcGkucHk=) | `95.74% <0.00%> (ø)` | |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `83.19% <0.00%> (ø)` | |
| [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `55.55% <0.00%> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | | |
| [superset-frontend/src/middleware/asyncEvent.ts](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvYXN5bmNFdmVudC50cw==) | | |
| [...hboard/util/getChartAndLabelComponentIdFromPath.js](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldENoYXJ0QW5kTGFiZWxDb21wb25lbnRJZEZyb21QYXRoLmpz) | | |
| [...shboard/util/charts/getFormDataWithExtraFilters.ts](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NoYXJ0cy9nZXRGb3JtRGF0YVdpdGhFeHRyYUZpbHRlcnMudHM=) | | |
| ... and [535 more](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=footer). Last update [ddbcf5b...1907dc2](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12472:
URL: https://github.com/apache/superset/pull/12472#issuecomment-759083184
# [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=h1) Report
> Merging [#12472](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=desc) (74acc83) into [master](https://codecov.io/gh/apache/superset/commit/ddbcf5b0e9a3ea7aed4d22e8438d9a75acd26275?el=desc) (ddbcf5b) will **increase** coverage by `1.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12472 +/- ##
==========================================
+ Coverage 62.53% 63.75% +1.21%
==========================================
Files 1014 486 -528
Lines 49509 29921 -19588
Branches 5078 0 -5078
==========================================
- Hits 30962 19075 -11887
+ Misses 18337 10846 -7491
+ Partials 210 0 -210
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.75% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.56% <0.00%> (-1.31%)` | :arrow_down: |
| [superset/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `86.04% <0.00%> (-0.07%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/css\_templates/api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9hcGkucHk=) | `95.74% <0.00%> (ø)` | |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `83.19% <0.00%> (ø)` | |
| [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `55.55% <0.00%> (ø)` | |
| [...-frontend/src/dashboard/containers/FilterScope.jsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0ZpbHRlclNjb3BlLmpzeA==) | | |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | | |
| [...d/src/dashboard/util/getLeafComponentIdFromPath.js](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExlYWZDb21wb25lbnRJZEZyb21QYXRoLmpz) | | |
| ... and [532 more](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=footer). Last update [ddbcf5b...74acc83](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12472:
URL: https://github.com/apache/superset/pull/12472#issuecomment-759083184
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12472:
URL: https://github.com/apache/superset/pull/12472#issuecomment-759083184
# [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=h1) Report
> Merging [#12472](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=desc) (74acc83) into [master](https://codecov.io/gh/apache/superset/commit/ddbcf5b0e9a3ea7aed4d22e8438d9a75acd26275?el=desc) (ddbcf5b) will **decrease** coverage by `3.31%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12472 +/- ##
==========================================
- Coverage 62.53% 59.22% -3.32%
==========================================
Files 1014 959 -55
Lines 49509 46784 -2725
Branches 5078 4339 -739
==========================================
- Hits 30962 27709 -3253
- Misses 18337 19075 +738
+ Partials 210 0 -210
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.60% <100.00%> (?)` | |
| javascript | `?` | |
| python | `64.08% <ø> (+0.35%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `64.10% <100.00%> (-18.88%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `8.00% <0.00%> (-84.00%)` | :arrow_down: |
| ... and [456 more](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=footer). Last update [ddbcf5b...1907dc2](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12472:
URL: https://github.com/apache/superset/pull/12472#issuecomment-759083184
# [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=h1) Report
> Merging [#12472](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=desc) (35b6b3e) into [master](https://codecov.io/gh/apache/superset/commit/ddbcf5b0e9a3ea7aed4d22e8438d9a75acd26275?el=desc) (ddbcf5b) will **increase** coverage by `0.96%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12472 +/- ##
==========================================
+ Coverage 62.53% 63.50% +0.96%
==========================================
Files 1014 486 -528
Lines 49509 29921 -19588
Branches 5078 0 -5078
==========================================
- Hits 30962 19001 -11961
+ Misses 18337 10920 -7417
+ Partials 210 0 -210
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.50% <ø> (-0.23%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.36%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.56% <0.00%> (-1.31%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.92% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.45% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `86.04% <0.00%> (-0.07%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| ... and [539 more](https://codecov.io/gh/apache/superset/pull/12472/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=footer). Last update [ddbcf5b...35b6b3e](https://codecov.io/gh/apache/superset/pull/12472?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #12472:
URL: https://github.com/apache/superset/pull/12472#discussion_r556188583
##########
File path: superset-frontend/src/SqlLab/components/SouthPane.jsx
##########
@@ -90,20 +90,11 @@ export class SouthPane extends React.PureComponent {
height: props.height,
};
this.southPaneRef = React.createRef();
- this.getSouthPaneHeight = this.getSouthPaneHeight.bind(this);
this.switchTab = this.switchTab.bind(this);
}
- UNSAFE_componentWillReceiveProps() {
- // south pane expands the entire height of the tab content on mount
- this.setState({ height: this.getSouthPaneHeight() });
- }
-
- // One layer of abstraction for easy spying in unit tests
- getSouthPaneHeight() {
- return this.southPaneRef.current
- ? this.southPaneRef.current.clientHeight
- : 0;
+ UNSAFE_componentWillReceiveProps(props) {
+ this.setState({ height: props.height });
Review comment:
Oh, yeah — good point! :-P
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #12472: fix (SQL Lab): disappearing results on tab switch
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #12472:
URL: https://github.com/apache/superset/pull/12472
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org