[jira] [Commented] (BOOKKEEPER-173) Uncontrolled number of threads in bookkeeper

["Flavio Junqueira (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212067#comment-13212067 ] 

Flavio Junqueira commented on BOOKKEEPER-173:
---------------------------------------------

I agree, callbackWorker is not used any longer and we may want to have a constructor that allows the application to pass a different OrderedSafeExecutor.
                
> Uncontrolled number of threads in bookkeeper
> --------------------------------------------
>
>                 Key: BOOKKEEPER-173
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-173
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Philipp Sushkin
>
> I am not sure if it is a but or not.
> Say, I do have pc with 256 cores, and there is following code in bookkeeper:
> {code:title=BookKeeper.java|borderStyle=solid}
> OrderedSafeExecutor callbackWorker = new OrderedSafeExecutor(Runtime.getRuntime().availableProcessors());
> OrderedSafeExecutor mainWorkerPool = new OrderedSafeExecutor(Runtime .getRuntime().availableProcessors());
> {code}
> As I understand, callbackWorker is not used at all, so it could be removed.
> Also could be required to get more control over mainWorkerPool (say, extract interface + pass instance through contructor).
> Myabe there are other places in library where some thread pools are created without ability to reuse existing thread pools in application.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira