You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/06 05:12:49 UTC
[GitHub] [spark] LuciferYang opened a new pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite in scala 2.13
LuciferYang opened a new pull request #29370:
URL: https://github.com/apache/spark/pull/29370
### What changes were proposed in this pull request?
The purpose of this pr is to partial resolve [SPARK-32526](https://issues.apache.org/jira/browse/SPARK-32526), fix `DataSourceV2AnalysisBaseSuite` related test cases and `TreeNodeSuite`, 72 failed cases in `sql/catalyst` module.
The main change of this pr as following:
- `Optimizer` and `Analyzer` are changed to pass compile, `ArrayBuffer` is not a `Seq` in scala 2.13, call `toSeq` method manually to compatible with Scala 2.12
- `m.mapValues().view.force` pattern return a `Map` in scala 2.12 but return a `IndexedSeq` in scala 2.13, call `toMap` method manually to compatible with Scala 2.12. `TreeNode` are changed to pass `DataSourceV2AnalysisBaseSuite` related test cases and `TreeNodeSuite` failed case.
### Why are the changes needed?
We need to support a Scala 2.13 build.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
- Scala 2.12: Pass the Jenkins or GitHub Action
- Scala 2.13: Do the following:
```
$ dev/change-scala-version.sh 2.13
```
**Before**
```
mvn clean test -pl sql/catalyst -am -Pscala-2.13 -DwildcardSuites=org.apache.spark.sql.catalyst.analysis.V2AppendDataANSIAnalysisSuite -Dtest=none
Tests: succeeded 10, failed 11, canceled 0, ignored 0, pending 0
*** 11 TESTS FAILED ***
mvn clean test -pl sql/catalyst -am -Pscala-2.13 -DwildcardSuites=org.apache.spark.sql.catalyst.analysis.V2AppendDataStrictAnalysisSuite -Dtest=none
Tests: succeeded 14, failed 11, canceled 0, ignored 0, pending 0
*** 11 TESTS FAILED ***
mvn clean test -pl sql/catalyst -am -Pscala-2.13 -DwildcardSuites=org.apache.spark.sql.catalyst.analysis.V2OverwriteByExpressionANSIAnalysisSuite -Dtest=none
Tests: succeeded 11, failed 12, canceled 0, ignored 0, pending 0
*** 12 TESTS FAILED ***
mvn clean test -pl sql/catalyst -am -Pscala-2.13 -DwildcardSuites=org.apache.spark.sql.catalyst.analysis.V2OverwriteByExpressionStrictAnalysisSuite -Dtest=none
Tests: succeeded 15, failed 12, canceled 0, ignored 0, pending 0
*** 12 TESTS FAILED ***
mvn clean test -pl sql/catalyst -am -Pscala-2.13 -DwildcardSuites=org.apache.spark.sql.catalyst.analysis.V2OverwritePartitionsDynamicANSIAnalysisSuite -Dtest=none
Tests: succeeded 10, failed 11, canceled 0, ignored 0, pending 0
*** 11 TESTS FAILED ***
mvn clean test -pl sql/catalyst -am -Pscala-2.13 -DwildcardSuites=org.apache.spark.sql.catalyst.analysis.V2OverwritePartitionsDynamicStrictAnalysisSuite -Dtest=none
Tests: succeeded 14, failed 11, canceled 0, ignored 0, pending 0
*** 11 TESTS FAILED ***
mvn clean test -pl sql/catalyst -am -Pscala-2.13 -DwildcardSuites=org.apache.spark.sql.catalyst.trees.TreeNodeSuite -Dtest=none
Tests: succeeded 21, failed 1, canceled 0, ignored 0, pending 0
*** 1 TEST FAILED ***
```
**After**
```
mvn clean test -pl sql/catalyst -am -Pscala-2.13 -DwildcardSuites=org.apache.spark.sql.catalyst.analysis.V2AppendDataANSIAnalysisSuite -Dtest=none
Tests: succeeded 21, failed 0, canceled 0, ignored 0, pending 0
All tests passed.
mvn clean test -pl sql/catalyst -am -Pscala-2.13 -DwildcardSuites=org.apache.spark.sql.catalyst.analysis.V2AppendDataStrictAnalysisSuite -Dtest=none
Tests: succeeded 25, failed 0, canceled 0, ignored 0, pending 0
All tests passed.
mvn clean test -pl sql/catalyst -am -Pscala-2.13 -DwildcardSuites=org.apache.spark.sql.catalyst.analysis.V2OverwriteByExpressionANSIAnalysisSuite -Dtest=none
Tests: succeeded 23, failed 0, canceled 0, ignored 0, pending 0
All tests passed.
mvn clean test -pl sql/catalyst -am -Pscala-2.13 -DwildcardSuites=org.apache.spark.sql.catalyst.analysis.V2OverwriteByExpressionStrictAnalysisSuite -Dtest=none
Tests: succeeded 27, failed 0, canceled 0, ignored 0, pending 0
All tests passed.
mvn clean test -pl sql/catalyst -am -Pscala-2.13 -DwildcardSuites=org.apache.spark.sql.catalyst.analysis.V2OverwritePartitionsDynamicANSIAnalysisSuite -Dtest=none
Tests: succeeded 21, failed 0, canceled 0, ignored 0, pending 0
mvn clean test -pl sql/catalyst -am -Pscala-2.13 -DwildcardSuites=org.apache.spark.sql.catalyst.analysis.V2OverwritePartitionsDynamicStrictAnalysisSuite -Dtest=none
Tests: succeeded 25, failed 0, canceled 0, ignored 0, pending 0
mvn clean test -pl sql/catalyst -am -Pscala-2.13 -DwildcardSuites=org.apache.spark.sql.catalyst.trees.TreeNodeSuite -Dtest=none
Tests: succeeded 22, failed 0, canceled 0, ignored 0, pending 0
All tests passed.
```
The whole 'SQL / catalyst' module test:
```
mvn clean test -pl sql/catalyst -Pscala-2.13
```
**Before**
```
Tests: succeeded 3853, failed 103, canceled 0, ignored 6, pending 0
*** 3 SUITES ABORTED ***
*** 103 TESTS FAILED ***
```
**After**
```
Tests: succeeded 3925, failed 31, canceled 0, ignored 6, pending 0
*** 3 SUITES ABORTED ***
*** 31 TESTS FAILED ***
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-670528851
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-673587065
Merged to master. I didn't resolve the JIRA yet because there are a few more tests to fix.
Good work! let's keep going.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669710240
> Thanks. You don't need to fix everything in one shot. Please group the failures and fix the one you think this is related to many others. You can proceed by suite by suite.
@dongjoon-hyun, this pr try to fix `DataSourceV2AnalysisBaseSuite` and `TreeNodeSuite` related test cases in scala 2.13 of `sql/catalyst` module, after this patch the failed cases count from 103 to 31, but no aborted cases fixed. Can you give a review？ thx ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-671150308
**[Test build #127260 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127260/testReport)** for PR 29370 at commit [`4018b1f`](https://github.com/apache/spark/commit/4018b1fb47e72f790609d4d2993e0ba90639fcc8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-670365030
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672954933
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672568214
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-671150461
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672954165
**[Test build #127385 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127385/testReport)** for PR 29370 at commit [`75d85ee`](https://github.com/apache/spark/commit/75d85ee0c01108408ec2e4dc8e301a26ea735a27).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-671409281
**[Test build #127283 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127283/testReport)** for PR 29370 at commit [`4018b1f`](https://github.com/apache/spark/commit/4018b1fb47e72f790609d4d2993e0ba90639fcc8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-671197552
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127260/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672667530
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672566297
The main change of Address [5328d33](https://github.com/apache/spark/pull/29370/commits/5328d33cc0fe138a5d1de9c73285ef262209e6dc) is add a sort
- Add a `sorted` to ensure `duplicateColumns` string in `SchemaUtils#checkColumnNameDuplication` method error message have a deterministic order because `IterableOps.groupBy` in Scala 2.13 and ` TraversableLike.groupBy` in Scala 2.12 have diffent result order
The effect as follow:
- Pass `SchemaUtilsSuite `
**Before**
```
Tests: succeeded 4035, failed 17, canceled 0, ignored 6, pending 0
*** 1 SUITE ABORTED ***
*** 17 TESTS FAILED ***
```
**After**
```
Tests: succeeded 4035, failed 17, canceled 0, ignored 6, pending 0
*** 1 SUITE ABORTED ***
*** 15 TESTS FAILED ***
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672556899
@srowen There are still some fixes left to commit and will be done today
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672560679
**[Test build #127360 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127360/testReport)** for PR 29370 at commit [`fca4fa7`](https://github.com/apache/spark/commit/fca4fa788c9f9bef0a465daca0bb4c1b62036b63).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672564201
**[Test build #127364 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127364/testReport)** for PR 29370 at commit [`5328d33`](https://github.com/apache/spark/commit/5328d33cc0fe138a5d1de9c73285ef262209e6dc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672567955
**[Test build #127367 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127367/testReport)** for PR 29370 at commit [`75d85ee`](https://github.com/apache/spark/commit/75d85ee0c01108408ec2e4dc8e301a26ea735a27).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-673893066
@srowen @HyukjinKwon I will try to give a new pr to resolve rest problems
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672562750
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672667560
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127356/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669710240
> Thanks. You don't need to fix everything in one shot. Please group the failures and fix the one you think this is related to many others. You can proceed by suite by suite.
@dongjoon-hyun, this pr try to fix `DataSourceV2AnalysisBaseSuite` and `TreeNodeSuite` related test cases in scala 2.13 of `sql/catalyst` module, after this pr the failed cases count from 103 to 31, but no aborted cases fixed. Can you give a review？ thx ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672560495
The main change of Address [fca4fa7](https://github.com/apache/spark/pull/29370/commits/fca4fa788c9f9bef0a465daca0bb4c1b62036b63) as follow:
- Add a `LongType` match to `ArraySetLike.nullValueHolder` to resolve problem as follow:
```
java.lang.Integer cannot be cast to java.lang.Long
java.lang.ClassCastException: java.lang.Integer cannot be cast to java.lang.Long
at scala.runtime.BoxesRunTime.unboxToLong(BoxesRunTime.java:103)
at scala.collection.mutable.ArrayBuilder$ofLong.addOne(ArrayBuilder.scala:321)
at scala.collection.mutable.Growable.$plus$eq(Growable.scala:38)
at scala.collection.mutable.Growable.$plus$eq$(Growable.scala:38)
at scala.collection.mutable.ArrayBuilder.$plus$eq(ArrayBuilder.scala:23)
at org.apache.spark.sql.catalyst.expressions.GeneratedClass$SpecificMutableProjection.ArrayUnion_0$(Unknown Source)
```
The effect as follow:
- Pass `CollectionExpressionsSuite `
**Before**
```
Tests: succeeded 4035, failed 20, canceled 0, ignored 6, pending 0
*** 1 SUITE ABORTED ***
*** 20 TESTS FAILED ***
```
**After**
```
Tests: succeeded 4035, failed 17, canceled 0, ignored 6, pending 0
*** 1 SUITE ABORTED ***
*** 17 TESTS FAILED ***
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-670359133
The main change of Address [beb3928](https://github.com/apache/spark/pull/29370/commits/beb3928397a81b2dd65d885b4e40e6e3c65376a3) is call `toMap` method of `Metadata#hash` method `case map` branch because `map.mapValues` return `Map` in Scala 2.12 and return `MapView` in Scala 2.13.
The effect as follow:
- Let `ExpressionSetSuite` no longer ABORTEDbut add 1 failed case because of `ExpressionSet` not implement `++` method
- Pass `MetadataSuite `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-671196619
**[Test build #127260 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127260/testReport)** for PR 29370 at commit [`4018b1f`](https://github.com/apache/spark/commit/4018b1fb47e72f790609d4d2993e0ba90639fcc8).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-671150461
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-670006325
This change itself looks fine. If you think the rest of the changes in sql / catalyst are similar, I'd make them in one go. If there are difficult or logically distinct other fixes, that can be another PR. They can all be attached to one JIRA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-673087923
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-671197546
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672659573
**[Test build #127367 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127367/testReport)** for PR 29370 at commit [`75d85ee`](https://github.com/apache/spark/commit/75d85ee0c01108408ec2e4dc8e301a26ea735a27).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #29370:
URL: https://github.com/apache/spark/pull/29370
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-670359133
The main change of Address [beb3928](https://github.com/apache/spark/pull/29370/commits/beb3928397a81b2dd65d885b4e40e6e3c65376a3) is call `toMap` method of `Metadata#hash` method `case map` branch because `map.mapValues` return `Map` in Scala 2.12 and return `MapView` in Scala 2.13.
The effect as follow:
- Let `ExpressionSetSuite` no longer ABORTED but add 1 failed case because of `ExpressionSet` not implement `++` method
- Pass `MetadataSuite `
**Before**
```
Tests: succeeded 3925, failed 31, canceled 0, ignored 6, pending 0
*** 3 SUITES ABORTED ***
*** 31 TESTS FAILED ***
```
**After**
```
Tests: succeeded 3973, failed 31, canceled 0, ignored 6, pending 0
*** 2 SUITES ABORTED ***
*** 31 TESTS FAILED ***
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672560937
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669764681
details of remaining failed cases already updated to the [attachment](https://issues.apache.org/jira/secure/attachment/13009170/failed-and-aborted-20200806), includes:
- LiteralExpressionSuite (1 FAILED)
- CollectionExpressionsSuite( 6 FAILED)
- StarJoinCostBasedReorderSuite ( 1 FAILED)
- ObjectExpressionsSuite( 2 FAILED)
- ExpressionParserSuite (1 FAILED)
- StringExpressionsSuite ( 1 FAILED)
- StringExpressionsSuite ( 1 FAILED)
- HigherOrderFunctionsSuite (1 FAILED)
- InferFiltersFromConstraintsSuite( 3 FAILED)
- ScalaReflectionSuite （2 FAILED）
- RowEncoderSuite (10 FAILED)
- SchemaUtilsSuite (2 FAILED)
- ArrayDataIndexedSeqSuite (ABORTED)
- ExpressionEncoderSuite (ABORTED)
- ExpressionSetSuite (ABORTED)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672576953
@srowen After [5328d33](https://github.com/apache/spark/pull/29370/commits/5328d33cc0fe138a5d1de9c73285ef262209e6dc), I think that there are no more similar problems that can be fixed.
The reasons for the remaining failure cases can be divided into two categories:
1. Need to deal with the pattern matching problem of 'ArraySeq' and 'ArrayBuffer' except 'StarJoinCostBasedReorderSuite`
2. `StarJoinCostBasedReorderSuite' a little special, the plan that caused the failure maybe also correct because it has the same cost as the expected plan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-670528851
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669699584
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669714401
cc @srowen from the numbers alone, this pr fixed about 70% failed cases of `sql/catalyst` module, do we accept partial fixed and fix the remaining cases in other pr?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669716503
I will update failure list to JIRA later after this pr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-671150308
**[Test build #127260 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127260/testReport)** for PR 29370 at commit [`4018b1f`](https://github.com/apache/spark/commit/4018b1fb47e72f790609d4d2993e0ba90639fcc8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-670527692
**[Test build #127188 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127188/testReport)** for PR 29370 at commit [`eeeb28a`](https://github.com/apache/spark/commit/eeeb28a15b9047f16049f0f1cecf97dbf6ab3562).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672554028
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672662497
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-671155276
@srowen agree with u, we can make a 'checkpoint' if [4018b1f](https://github.com/apache/spark/pull/29370/commits/4018b1fb47e72f790609d4d2993e0ba90639fcc8) no problem, and I will update the PR description.
I found that It is difficult to fix the cases caused by `WrappedArray`.
For example, `WrappedArray.make` method return `WrappedArray` in Scala 2.12 and return `ArraySeq` in Scala 2.13, then in Scala 2.13 `Row.getSeq` method can not convert `ArraySeq` to a `Seq` type, the failed cases in `RowEncoderSuite` related to this problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669764681
details of remaining failed cases already updated to the [attachment](https://issues.apache.org/jira/secure/attachment/13009170/failed-and-aborted-20200806) and added comments in [SPARK-32526](https://issues.apache.org/jira/browse/SPARK-32526)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-670359133
The main change of Address [beb3928](https://github.com/apache/spark/pull/29370/commits/beb3928397a81b2dd65d885b4e40e6e3c65376a3) is call `toMap` method of `Metadata#hash` method `case map` branch because `map.mapValues` return `Map` in Scala 2.12 and return `MapView` in Scala 2.13.
The effect as follow:
- Let `ExpressionSetSuite` no longer ABORTEDbut add 1 failed case because of `ExpressionSet` not implement `++` method
- Pass `MetadataSuite `
**Before**
```
Tests: succeeded 3925, failed 31, canceled 0, ignored 6, pending 0
*** 3 SUITES ABORTED ***
*** 31 TESTS FAILED ***
```
**After**
```
Tests: succeeded 3973, failed 31, canceled 0, ignored 6, pending 0
*** 2 SUITES ABORTED ***
*** 31 TESTS FAILED ***
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672558251
The main change of Address [db90b1a](https://github.com/apache/spark/pull/29370/commits/db90b1acc87d709ca7643a258eccc31a2ff219ca) as follow:
- Call `toSeq` in `AstBuilder#visitFunctionCall`, otherwise `ctx.argument.asScala.map(expression)` is `Buffer` in Scala 2.13
The effect as follow:
- Pass `ExpressionParserSuite `
**Before**
```
Tests: succeeded 4035, failed 21, canceled 0, ignored 6, pending 0
*** 1 SUITE ABORTED ***
*** 21 TESTS FAILED ***
```
**After**
```
Tests: succeeded 4035, failed 20, canceled 0, ignored 6, pending 0
*** 1 SUITE ABORTED ***
*** 20 TESTS FAILED ***
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-670340921
**[Test build #127179 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127179/testReport)** for PR 29370 at commit [`beb3928`](https://github.com/apache/spark/commit/beb3928397a81b2dd65d885b4e40e6e3c65376a3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-670381323
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672666660
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669716503
I will update failure list to JIRA later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-670381323
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-670380804
**[Test build #127188 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127188/testReport)** for PR 29370 at commit [`eeeb28a`](https://github.com/apache/spark/commit/eeeb28a15b9047f16049f0f1cecf97dbf6ab3562).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669699869
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672664268
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672567955
**[Test build #127367 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127367/testReport)** for PR 29370 at commit [`75d85ee`](https://github.com/apache/spark/commit/75d85ee0c01108408ec2e4dc8e301a26ea735a27).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672554028
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-671410059
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-671409281
**[Test build #127283 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127283/testReport)** for PR 29370 at commit [`4018b1f`](https://github.com/apache/spark/commit/4018b1fb47e72f790609d4d2993e0ba90639fcc8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672562750
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-673087923
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-670365030
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-670381199
The main change of Address [eeeb28a](https://github.com/apache/spark/pull/29370/commits/eeeb28a15b9047f16049f0f1cecf97dbf6ab3562) impl `contact` method of `ExpressionSet` in Scala 2.13 version refer to `ExpressionSet` in Scala 2.12
The effect as follow:
- Pass `ExpressionSetSuite `
- Pass `InferFiltersFromConstraintsSuite `
**Before**
```
Tests: succeeded 3973, failed 31, canceled 0, ignored 6, pending 0
*** 2 SUITES ABORTED ***
*** 31 TESTS FAILED ***
```
**After**
```
Tests: succeeded 3973, failed 31, canceled 0, ignored 6, pending 0
*** 2 SUITES ABORTED ***
*** 27 TESTS FAILED ***
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-670339108
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672662526
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-671563716
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-671155276
@srowen agree with u, we can make a 'checkpoint' if [4018b1f](https://github.com/apache/spark/pull/29370/commits/4018b1fb47e72f790609d4d2993e0ba90639fcc8) no problem, and I will update the PR description.
I found that It is difficult to fix the cases caused by `WrappedArray`.
For example, `WrappedArray.make` method return `WrappedArray` in Scala 2.12 and return `ArraySeq` in Scala 2.13, then in Scala 2.13 `Row.getSeq` method can not convert `ArraySeq` to `Seq` type, the failed cases in `RowEncoderSuite` related to this problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-671410059
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-673875162
Nice to get this being fixed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669714401
cc @srowen from the numbers alone, this pr fixed about 70% failed cases of `sql/catalyst` module, do we accept partial fixed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672954933
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672664303
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127360/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-671155276
@srowen agree with u, we can make a 'checkpoint' if [4018b1f](https://github.com/apache/spark/pull/29370/commits/4018b1fb47e72f790609d4d2993e0ba90639fcc8) no problem.
I found that It is difficult to fix the cases caused by `WrappedArray`.
For example, `WrappedArray.make` method return `WrappedArray` in Scala 2.12 and return `ArraySeq` in Scala 2.13, then in Scala 2.13 `Row.getSeq` method can not convert `ArraySeq` to a `Seq` type, the failed cases in `RowEncoderSuite` related to this problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672566297
The main change of Address [5328d33](https://github.com/apache/spark/pull/29370/commits/5328d33cc0fe138a5d1de9c73285ef262209e6dc) is add a sort
- Add a `sorted` to ensure `duplicateColumns` string in `SchemaUtils#checkColumnNameDuplication` method error message have a deterministic order because
`IterableOps.groupBy` in Scala 2.13 and ` TraversableLike.groupBy` in Scala 2.12 have diffent result order
`IterableOps#groupBy` 和 `TraversableLike#groupBy` 的结果具有不同的顺序
The effect as follow:
- Pass `SchemaUtilsSuite `
**Before**
```
Tests: succeeded 4035, failed 17, canceled 0, ignored 6, pending 0
*** 1 SUITE ABORTED ***
*** 17 TESTS FAILED ***
```
**After**
```
Tests: succeeded 4035, failed 17, canceled 0, ignored 6, pending 0
*** 1 SUITE ABORTED ***
*** 15 TESTS FAILED ***
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672568214
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669710240
> Thanks. You don't need to fix everything in one shot. Please group the failures and fix the one you think this is related to many others. You can proceed by suite by suite.
@dongjoon-hyun, this pr try to fix `DataSourceV2AnalysisBaseSuite` and `TreeNodeSuite` related test cases in scala 2.13 of `sql/catalyst` module, after this pr the failed cases count from 103 decrease to; 31, but no aborted cases fixed. Can you give a review？ thx ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-671945416
If there aren't any more fixes that are similar here, I can merge this. We can add more now if there are others that are easily fixable in SQL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-671563716
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-670359133
The main change of Address [beb3928](https://github.com/apache/spark/pull/29370/commits/beb3928397a81b2dd65d885b4e40e6e3c65376a3) is call `toMap` method of `Metadata#hash` method `case map` branch because `map.mapValues` return `Map` in Scala 2.12 and return `MapView` in Scala 2.13.
The effect as follow:
- Let `ExpressionSetSuite` no longer ABORTEDbut add 1 failed case because of `ExpressionSet` not implement `++` method
- Pass `MetadataSuite `
**Before**
```
Tests: succeeded 3925, failed 31, canceled 0, ignored 6, pending 0
*** 3 SUITES ABORTED ***
*** 31 TESTS FAILED ***
```
**After**
```
Tests: succeeded 3925, failed 31, canceled 0, ignored 6, pending 0
*** 2 SUITES ABORTED ***
*** 31 TESTS FAILED ***
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-671407615
Jenkins retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669714401
cc @srowen from the numbers alone, this pr fixed about 70% failed cases of `sql/catalyst` module now, do we accept partial fixed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-671152179
The main change of Address [4018b1f](https://github.com/apache/spark/pull/29370/commits/4018b1fb47e72f790609d4d2993e0ba90639fcc8) as follow:
- `GenericArrayData` not accept `ArrayBuffer` input, call `toSeq` for Scala version compatibility
- Call `toSeq` in `RandomDataGenerator#randomRow` method to ensure contents of `fields` is `Seq` not `ArrayBuffer`
- Call `toSeq` Let `JacksonParser#parse` still return a `Seq` because the check method of `JacksonParserSuite#"skipping rows using pushdown filters"` dependence on `Seq` type
The effect as follow:
- Let `ArrayDataIndexedSeqSuite` no longer ABORTED and all pass
- Pass `StringExpressionsSuite `
- Pass `JacksonParserSuite `
- Pass `HigherOrderFunctionsSuite `
- Partial Pass `CollectionExpressionsSuite ` , failed case from 6 to 3
**Before**
```
Tests: succeeded 3973, failed 31, canceled 0, ignored 6, pending 0
*** 2 SUITES ABORTED ***
*** 27 TESTS FAILED ***
```
**After**
```
Tests: succeeded 4035, failed 21, canceled 0, ignored 6, pending 0
*** 1 SUITE ABORTED ***
*** 21 TESTS FAILED ***
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672952703
Jenkins retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672553768
**[Test build #127356 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127356/testReport)** for PR 29370 at commit [`db90b1a`](https://github.com/apache/spark/commit/db90b1acc87d709ca7643a258eccc31a2ff219ca).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672560937
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-670338662
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-673086860
**[Test build #127385 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127385/testReport)** for PR 29370 at commit [`75d85ee`](https://github.com/apache/spark/commit/75d85ee0c01108408ec2e4dc8e301a26ea735a27).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-671197546
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669699869
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672954165
**[Test build #127385 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127385/testReport)** for PR 29370 at commit [`75d85ee`](https://github.com/apache/spark/commit/75d85ee0c01108408ec2e4dc8e301a26ea735a27).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-671561807
**[Test build #127283 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127283/testReport)** for PR 29370 at commit [`4018b1f`](https://github.com/apache/spark/commit/4018b1fb47e72f790609d4d2993e0ba90639fcc8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-670380804
**[Test build #127188 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127188/testReport)** for PR 29370 at commit [`eeeb28a`](https://github.com/apache/spark/commit/eeeb28a15b9047f16049f0f1cecf97dbf6ab3562).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-670339108
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-670935968
Looking good. I think you're welcome to keep going and we can 'checkpoint' and commit some fixes whenever there is a logical and large enough group of them to commit. That could be now too, up to you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672662497
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669716503
I will update failure list to JIRA after this pr later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672666660
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-670284638
@HyukjinKwon @srowen ok ~ let me give it a try~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite in scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-669699584
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-670282736
Yeah, let's try to do it in one go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org