You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Philippe Gassmann (JIRA)" <ji...@apache.org> on 2006/02/01 12:27:03 UTC

[jira] Created: (COCOON-1758) Form locale never used in JXMacros

Form locale never used in JXMacros
----------------------------------

         Key: COCOON-1758
         URL: http://issues.apache.org/jira/browse/COCOON-1758
     Project: Cocoon
        Type: Bug
  Components: Blocks: Forms  
    Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9-dev (current SVN)    
    Reporter: Philippe Gassmann


The JXMacroHelper is created with : <jx:set var="cformsHelper" value="#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}"/>

So the locale is get from sitemap parameters. 
the locale attribute of the form is then never used.

I will provide a patch as soon as possible

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (COCOON-1758) Form locale never used in JXMacros

Posted by "Philippe Gassmann (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/COCOON-1758?page=comments#action_12367201 ] 

Philippe Gassmann commented on COCOON-1758:
-------------------------------------------

I will try to provide a patch ASAP.

> Form locale never used in JXMacros
> ----------------------------------
>
>          Key: COCOON-1758
>          URL: http://issues.apache.org/jira/browse/COCOON-1758
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Forms
>     Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
>     Reporter: Philippe Gassmann
>     Assignee: Jean-Baptiste Quenot
>  Attachments: 20060201-cocoon-forms-1758
>
> The JXMacroHelper is created with : <jx:set var="cformsHelper" value="#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}"/>
> So the locale is get from sitemap parameters. 
> the locale attribute of the form is then never used.
> I will provide a patch as soon as possible

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (COCOON-1758) Form locale never used in JXMacros

Posted by "Antonio Gallardo (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1758?page=all ]

Antonio Gallardo reassigned COCOON-1758:
----------------------------------------

    Assignee: Antonio Gallardo

> Form locale never used in JXMacros
> ----------------------------------
>
>                 Key: COCOON-1758
>                 URL: http://issues.apache.org/jira/browse/COCOON-1758
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Forms
>    Affects Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9
>            Reporter: Philippe Gassmann
>         Assigned To: Antonio Gallardo
>         Attachments: 20060201-cocoon-forms-1758, patch.txt, patch1.txt
>
>
> The JXMacroHelper is created with : <jx:set var="cformsHelper" value="#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}"/>
> So the locale is get from sitemap parameters. 
> the locale attribute of the form is then never used.
> I will provide a patch as soon as possible

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (COCOON-1758) Form locale never used in JXMacros

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1758?page=all ]

Jean-Baptiste Quenot reassigned COCOON-1758:
--------------------------------------------

    Assign To: Jean-Baptiste Quenot

> Form locale never used in JXMacros
> ----------------------------------
>
>          Key: COCOON-1758
>          URL: http://issues.apache.org/jira/browse/COCOON-1758
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Forms
>     Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
>     Reporter: Philippe Gassmann
>     Assignee: Jean-Baptiste Quenot
>  Attachments: 20060201-cocoon-forms-1758
>
> The JXMacroHelper is created with : <jx:set var="cformsHelper" value="#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}"/>
> So the locale is get from sitemap parameters. 
> the locale attribute of the form is then never used.
> I will provide a patch as soon as possible

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (COCOON-1758) Form locale never used in JXMacros

Posted by "Simone Gianni (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/COCOON-1758?page=comments#action_12427261 ] 
            
Simone Gianni commented on COCOON-1758:
---------------------------------------

The code in jx-macros actually calls cocoon.parameter.getParameter('locale'). Unfortunately, if a locale is not specified, this brings to an exception, since a default value is not given.

This beaks compatibility with previous 2.1 versions, and in general IMMO having to specify explicitly a local for every form template is verbose.

I think this should be substituted with getParameter('locale',null), and subseguently in the JXMacrosHelper the given locale must be used, if present, otherwise the request one, otherwise the default one.

I have this fix on my version, but wanted to know if this is the intended behaviour before committing.

> Form locale never used in JXMacros
> ----------------------------------
>
>                 Key: COCOON-1758
>                 URL: http://issues.apache.org/jira/browse/COCOON-1758
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Forms
>    Affects Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9
>            Reporter: Philippe Gassmann
>         Assigned To: Antonio Gallardo
>             Fix For: 2.2-dev (Current SVN), 2.1.10-dev (current SVN)
>
>         Attachments: 20060201-cocoon-forms-1758, patch.txt, patch1.txt
>
>
> The JXMacroHelper is created with : <jx:set var="cformsHelper" value="#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}"/>
> So the locale is get from sitemap parameters. 
> the locale attribute of the form is then never used.
> I will provide a patch as soon as possible

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (COCOON-1758) Form locale never used in JXMacros

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1758?page=all ]

Jean-Baptiste Quenot updated COCOON-1758:
-----------------------------------------

    Attachment:     (was: 20060201-cocoon-forms-1758)

> Form locale never used in JXMacros
> ----------------------------------
>
>          Key: COCOON-1758
>          URL: http://issues.apache.org/jira/browse/COCOON-1758
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Forms
>     Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
>     Reporter: Philippe Gassmann
>     Assignee: Jean-Baptiste Quenot
>  Attachments: 20060201-cocoon-forms-1758
>
> The JXMacroHelper is created with : <jx:set var="cformsHelper" value="#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}"/>
> So the locale is get from sitemap parameters. 
> the locale attribute of the form is then never used.
> I will provide a patch as soon as possible

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (COCOON-1758) Form locale never used in JXMacros

Posted by "Carlos Chávez (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1758?page=all ]

Carlos Chávez updated COCOON-1758:
----------------------------------

    Attachment: patch1.txt
                patch.txt

Hi to all.

the first patch try to get correctly the locale parameter from the sitemap parameters, if the locale parameter does not exists we pass a empty string.

the second patch fix the method to test against empty string not only null value, for example from the jx-macro we pass a empty string if the locale parameter does not exists, so we want to use the default Locale.

Cheers.
Carlos Chávez.


> Form locale never used in JXMacros
> ----------------------------------
>
>                 Key: COCOON-1758
>                 URL: http://issues.apache.org/jira/browse/COCOON-1758
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Forms
>    Affects Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9
>            Reporter: Philippe Gassmann
>         Attachments: 20060201-cocoon-forms-1758, patch.txt, patch1.txt
>
>
> The JXMacroHelper is created with : <jx:set var="cformsHelper" value="#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}"/>
> So the locale is get from sitemap parameters. 
> the locale attribute of the form is then never used.
> I will provide a patch as soon as possible

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (COCOON-1758) Form locale never used in JXMacros

Posted by "Philippe Gassmann (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/COCOON-1758?page=comments#action_12367199 ] 

Philippe Gassmann commented on COCOON-1758:
-------------------------------------------

Your patch does not solve the problem ; I think the management of locale in forms has to be deeply refactored

> Form locale never used in JXMacros
> ----------------------------------
>
>          Key: COCOON-1758
>          URL: http://issues.apache.org/jira/browse/COCOON-1758
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Forms
>     Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
>     Reporter: Philippe Gassmann
>     Assignee: Jean-Baptiste Quenot
>  Attachments: 20060201-cocoon-forms-1758
>
> The JXMacroHelper is created with : <jx:set var="cformsHelper" value="#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}"/>
> So the locale is get from sitemap parameters. 
> the locale attribute of the form is then never used.
> I will provide a patch as soon as possible

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (COCOON-1758) Form locale never used in JXMacros

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1758?page=all ]

Jean-Baptiste Quenot updated COCOON-1758:
-----------------------------------------

    Attachment: 20060201-cocoon-forms-1758

> Form locale never used in JXMacros
> ----------------------------------
>
>          Key: COCOON-1758
>          URL: http://issues.apache.org/jira/browse/COCOON-1758
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Forms
>     Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
>     Reporter: Philippe Gassmann
>     Assignee: Jean-Baptiste Quenot
>  Attachments: 20060201-cocoon-forms-1758
>
> The JXMacroHelper is created with : <jx:set var="cformsHelper" value="#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}"/>
> So the locale is get from sitemap parameters. 
> the locale attribute of the form is then never used.
> I will provide a patch as soon as possible

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (COCOON-1758) Form locale never used in JXMacros

Posted by "Antonio Gallardo (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/COCOON-1758?page=comments#action_12427267 ] 
            
Antonio Gallardo commented on COCOON-1758:
------------------------------------------

Thanks for the feedback Simone. You are fully right. I reviewed the Carlos patch against the repository and is not the same. I recall I did some tests before committing to checking if this is working as expected. After testing, for some reason I forgot to revert my test changes. In short:

I bad commit was:

cocoon.parameters.getParameter('locale')

and patch reads:

cocoon.parameters.getParameter('locale','')

(please note the "empty" string as default value.

I am going to commit the "fix to the fix", right now. :-)

Thanks again for spotting the issue.

> Form locale never used in JXMacros
> ----------------------------------
>
>                 Key: COCOON-1758
>                 URL: http://issues.apache.org/jira/browse/COCOON-1758
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Forms
>    Affects Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9
>            Reporter: Philippe Gassmann
>         Assigned To: Antonio Gallardo
>             Fix For: 2.2-dev (Current SVN), 2.1.10-dev (current SVN)
>
>         Attachments: 20060201-cocoon-forms-1758, patch.txt, patch1.txt
>
>
> The JXMacroHelper is created with : <jx:set var="cformsHelper" value="#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}"/>
> So the locale is get from sitemap parameters. 
> the locale attribute of the form is then never used.
> I will provide a patch as soon as possible

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: jira showing svn commits

Posted by David Crossley <cr...@apache.org>.
Reinhard Poetz wrote:
> Marc Portier wrote:
> 
> >hm, apparently it's not picking up on just a jira-id in the log:
> >
> >this recent commit e.g.
> >  http://svn.apache.org/viewvc?view=rev&revision=430378
> >
> >isn't listed under the svn-tab on the issue it references in the
> >commit-message:
> >  https://issues.apache.org/jira/browse/COCOON-1687
> >
> >any specific detail on what to do to make it work?
> 
> You have to add the issue _key_ at the beginning of your commit message.  
> In your case "COCOON-1687".

I reckon anywhere in the commit log message will
do it.

-David

Re: jira showing svn commits

Posted by Reinhard Poetz <re...@apache.org>.
Marc Portier wrote:

> hm, apparently it's not picking up on just a jira-id in the log:
> 
> this recent commit e.g.
>   http://svn.apache.org/viewvc?view=rev&revision=430378
> 
> isn't listed under the svn-tab on the issue it references in the
> commit-message:
>   https://issues.apache.org/jira/browse/COCOON-1687
> 
> any specific detail on what to do to make it work?

You have to add the issue _key_ at the beginning of your commit message.  In 
your case "COCOON-1687".

-- 
Reinhard Pötz           Independent Consultant, Trainer & (IT)-Coach 

{Software Engineering, Open Source, Web Applications, Apache Cocoon}

                                        web(log): http://www.poetz.cc
--------------------------------------------------------------------

		
___________________________________________________________ 
Telefonate ohne weitere Kosten vom PC zum PC: http://messenger.yahoo.de

jira showing svn commits (was Re: [jira] Commented: (COCOON-1758) Form locale never used in JXMacros)

Posted by Marc Portier <mp...@outerthought.org>.

Joerg Heinicke wrote:
> On 16.08.2006 15:22, Marc Portier (JIRA) wrote:
>>     [
>> http://issues.apache.org/jira/browse/COCOON-1758?page=comments#action_12428388
>> ]             Marc Portier commented on COCOON-1758:
>> --------------------------------------
>>
>> Adding the svn-update references to ease tracking:
>>
>> http://svn.apache.org/viewvc?view=rev&revision=427436
>> http://svn.apache.org/viewvc?view=rev&revision=430438
> 
> Hi Marc,
> 
> Jira is doing it for us:
> http://issues.apache.org/jira/browse/COCOON-1758?page=com.atlassian.jira.plugin.ext.subversion:subversion-commits-tabpanel
> 
> It probably needs a reference to the issue number in the commit message.
> Antonio did this exemplary :)
> 

mighty cool,
thx, Joerg, for waking me up on this


hm, apparently it's not picking up on just a jira-id in the log:

this recent commit e.g.
  http://svn.apache.org/viewvc?view=rev&revision=430378

isn't listed under the svn-tab on the issue it references in the
commit-message:
  https://issues.apache.org/jira/browse/COCOON-1687

any specific detail on what to do to make it work?

-marc=
-- 
Marc Portier                            http://outerthought.org/
Outerthought - Open Source, Java & XML Competence Support Center
Read my weblog at                http://blogs.cocoondev.org/mpo/
mpo@outerthought.org                              mpo@apache.org


Re: [jira] Commented: (COCOON-1758) Form locale never used in JXMacros

Posted by Joerg Heinicke <jo...@gmx.de>.
On 16.08.2006 15:22, Marc Portier (JIRA) wrote:
>     [ http://issues.apache.org/jira/browse/COCOON-1758?page=comments#action_12428388 ] 
>             
> Marc Portier commented on COCOON-1758:
> --------------------------------------
> 
> Adding the svn-update references to ease tracking:
> 
> http://svn.apache.org/viewvc?view=rev&revision=427436
> http://svn.apache.org/viewvc?view=rev&revision=430438

Hi Marc,

Jira is doing it for us:
http://issues.apache.org/jira/browse/COCOON-1758?page=com.atlassian.jira.plugin.ext.subversion:subversion-commits-tabpanel
It probably needs a reference to the issue number in the commit message. 
Antonio did this exemplary :)

Jörg

[jira] Commented: (COCOON-1758) Form locale never used in JXMacros

Posted by "Marc Portier (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/COCOON-1758?page=comments#action_12428388 ] 
            
Marc Portier commented on COCOON-1758:
--------------------------------------

Adding the svn-update references to ease tracking:

http://svn.apache.org/viewvc?view=rev&revision=427436
http://svn.apache.org/viewvc?view=rev&revision=430438

> Form locale never used in JXMacros
> ----------------------------------
>
>                 Key: COCOON-1758
>                 URL: http://issues.apache.org/jira/browse/COCOON-1758
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Forms
>    Affects Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9
>            Reporter: Philippe Gassmann
>         Assigned To: Antonio Gallardo
>             Fix For: 2.2-dev (Current SVN), 2.1.10-dev (current SVN)
>
>         Attachments: 20060201-cocoon-forms-1758, patch.txt, patch1.txt
>
>
> The JXMacroHelper is created with : <jx:set var="cformsHelper" value="#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}"/>
> So the locale is get from sitemap parameters. 
> the locale attribute of the form is then never used.
> I will provide a patch as soon as possible

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (COCOON-1758) Form locale never used in JXMacros

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1758?page=all ]

Jean-Baptiste Quenot updated COCOON-1758:
-----------------------------------------

    Attachment: 20060201-cocoon-forms-1758

What about this patch?

> Form locale never used in JXMacros
> ----------------------------------
>
>          Key: COCOON-1758
>          URL: http://issues.apache.org/jira/browse/COCOON-1758
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Forms
>     Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
>     Reporter: Philippe Gassmann
>     Assignee: Jean-Baptiste Quenot
>  Attachments: 20060201-cocoon-forms-1758
>
> The JXMacroHelper is created with : <jx:set var="cformsHelper" value="#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}"/>
> So the locale is get from sitemap parameters. 
> the locale attribute of the form is then never used.
> I will provide a patch as soon as possible

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (COCOON-1758) Form locale never used in JXMacros

Posted by "Antonio Gallardo (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/COCOON-1758?page=comments#action_12427268 ] 
            
Antonio Gallardo commented on COCOON-1758:
------------------------------------------

The fix is now on the repository. Please cross check if this works. Thanks again for spotting the error.

> Form locale never used in JXMacros
> ----------------------------------
>
>                 Key: COCOON-1758
>                 URL: http://issues.apache.org/jira/browse/COCOON-1758
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Forms
>    Affects Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9
>            Reporter: Philippe Gassmann
>         Assigned To: Antonio Gallardo
>             Fix For: 2.2-dev (Current SVN), 2.1.10-dev (current SVN)
>
>         Attachments: 20060201-cocoon-forms-1758, patch.txt, patch1.txt
>
>
> The JXMacroHelper is created with : <jx:set var="cformsHelper" value="#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}"/>
> So the locale is get from sitemap parameters. 
> the locale attribute of the form is then never used.
> I will provide a patch as soon as possible

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (COCOON-1758) Form locale never used in JXMacros

Posted by "Antonio Gallardo (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1758?page=all ]

Antonio Gallardo closed COCOON-1758.
------------------------------------

    Fix Version/s: 2.2-dev (Current SVN)
                   2.1.10-dev (current SVN)
       Resolution: Fixed

Hi Carlos, I am glad to see you contributing back to the cocoon community! Thanks for the patch. It was applied with minor changes. Please feel free to reopen the issue if needed.

> Form locale never used in JXMacros
> ----------------------------------
>
>                 Key: COCOON-1758
>                 URL: http://issues.apache.org/jira/browse/COCOON-1758
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Forms
>    Affects Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9
>            Reporter: Philippe Gassmann
>         Assigned To: Antonio Gallardo
>             Fix For: 2.2-dev (Current SVN), 2.1.10-dev (current SVN)
>
>         Attachments: 20060201-cocoon-forms-1758, patch.txt, patch1.txt
>
>
> The JXMacroHelper is created with : <jx:set var="cformsHelper" value="#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}"/>
> So the locale is get from sitemap parameters. 
> the locale attribute of the form is then never used.
> I will provide a patch as soon as possible

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (COCOON-1758) Form locale never used in JXMacros

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1758?page=all ]

Jean-Baptiste Quenot reassigned COCOON-1758:
--------------------------------------------

    Assign To:     (was: Jean-Baptiste Quenot)

Sorry I won't be able to work on this anymore

> Form locale never used in JXMacros
> ----------------------------------
>
>          Key: COCOON-1758
>          URL: http://issues.apache.org/jira/browse/COCOON-1758
>      Project: Cocoon
>         Type: Bug

>   Components: Blocks: Forms
>     Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9
>     Reporter: Philippe Gassmann
>  Attachments: 20060201-cocoon-forms-1758
>
> The JXMacroHelper is created with : <jx:set var="cformsHelper" value="#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}"/>
> So the locale is get from sitemap parameters. 
> the locale attribute of the form is then never used.
> I will provide a patch as soon as possible

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira