[GitHub] [incubator-inlong] KevinWen007 commented on a change in pull request #2387: [INLONG-2346][Feature][InLong-Sort] Support avro and canal formats for sort sink

[GitBox <gi...@apache.org>]

KevinWen007 commented on a change in pull request #2387:
URL: https://github.com/apache/incubator-inlong/pull/2387#discussion_r807732040



##########
File path: inlong-sort/sort-formats/format-base/src/main/java/org/apache/inlong/sort/formats/base/TableFormatUtils.java
##########
@@ -331,7 +343,7 @@ public static LogicalType deriveLogicalType(FormatInfo formatInfo) {
         } else if (formatInfo instanceof DateFormatInfo) {
             return new DateType();
         } else if (formatInfo instanceof TimestampFormatInfo) {
-            return new TimestampType();
+            return new TimestampType(DEFAULT_PRECISION_FOR_TIMESTAMP);

Review comment:
       Precision is not supported in current TimestampFormatInfo, and modification above is only to support avro format. Precision is not used elsewhere except avro.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org