You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prasadwagle <gi...@git.apache.org> on 2016/03/07 22:41:19 UTC
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-666] Change location of...
GitHub user prasadwagle opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/766
[ZEPPELIN-666] Change location of notebook authorization information.
### What is this PR for?
Currently, notebook authorization information is stored in the note file (note.json). The purpose of this PR is to store the authorization information in notebook-authorization.json in the conf directory. There is no change to the user experience.
The long-term goal is to make NotebookAuthorization an interface with implementation to store the authorization information with Shiro.
### What type of PR is it?
Improvement
### Todos
* [ ] - Code review
### What is the Jira issue?
[ZEPPELIN-666](https://issues.apache.org/jira/browse/ZEPPELIN-666)
### How should this be tested?
1. Enable Basic Auth Security by changing conf/shiro.ini.
1. Create a note. By default all operations are allowed by any authenticated user.
1. Update readers, writers and owners by clicking on the lock icon in the top right area.
1. Check if users can or cannot perform operations according to the permissions.
1. Check if notebook-authorization.json has correct authorization information.
### Screenshots (if appropriate)
Not applicable.
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prasadwagle/incubator-zeppelin ZEPPELIN-666
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/766.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #766
----
commit 1fe840824b860bbc25173bfe0006a5f0b8d7ce2e
Author: Prasad Wagle <pw...@twitter.com>
Date: 2016-03-07T20:59:05Z
Store notebook authorization information in a file separate from note file
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-666] Change location of...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/766#issuecomment-195827838
@prasadwagle Thanks for the contribution. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-666] Change location of...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/766#issuecomment-195505005
Could you re-trigger CI and see it's passing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-666] Change location of...
Posted by prasadwagle <gi...@git.apache.org>.
Github user prasadwagle commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/766#issuecomment-196050734
Thanks @Leemoonsoo for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-666] Change location of...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/766
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-666] Change location of...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/766#issuecomment-194627179
Thank you for the contribution. I tested and working well.
One thing i found is, NotebookAuthorization.removeNote() is never called. which i think supposed to be called on note removal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---