You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2019/06/20 18:27:21 UTC

[GitHub] [fineract] vorburger commented on a change in pull request #593: Create one-touch deploy with docker

vorburger commented on a change in pull request #593: Create one-touch deploy with docker
URL: https://github.com/apache/fineract/pull/593#discussion_r295935316
 
 

 ##########
 File path: docker/build.gradle
 ##########
 @@ -0,0 +1,553 @@
+/**
 
 Review comment:
   @conradsp this appears to be a verbatim copy/paste of the `build.gradle` at the root of the project? We should avoid this - you know how these things go, I guarantee that this won't be kept up to date... if the reason that you to do this was because you couldn't get Docker to access files outside of the `docker/` sub-directory you're introducing here, then if I were you I would probably just put the `Dockerfile` at the root - not the end of the world, IMHO.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services