You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/11 13:12:28 UTC

[GitHub] [tvm] tqchen edited a comment on pull request #7717: [Vulkan] Support uniform buffer object for passing many scalar arguments

tqchen edited a comment on pull request #7717:
URL: https://github.com/apache/tvm/pull/7717#issuecomment-817305706


    Sorry that i didn't get a chance to review. Here are some items that needs to be fixed as followup PRs:
   
   - Let us not use GetMaxPushConstantSize, as it is dynamic across devices, and the code won't behave correctly if we are doing cross compilation(where we compile on a machine that does not have vulkan), we should use a minimum TVM default (e.g. 128 bytes).
   - I see a few places where delete is used, always prefer std::unique_ptr when possible instead of delete
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org