[jira] [Reopened] (AMBARI-12906) Alert notifications are created even if credential fields are left empty

["Antonenko Alexander (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AMBARI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonenko Alexander reopened AMBARI-12906:
------------------------------------------

Before creating new util methods/functions, please do investigation, to check if we already have that functionality.

In this commit you added isEmptyOrSpaces. There is no need in it. We already have Em.isBlank. please remove isEmptyOrSpaces and use Em.isBlank instead.

p.s. One more thing, next time you ask to make a review thru email please inform that there is no need in it, because additionally you asked someone else and he already did that. So we will escape doing double job.


> Alert notifications are created even if credential fields are left empty
> ------------------------------------------------------------------------
>
>                 Key: AMBARI-12906
>                 URL: https://issues.apache.org/jira/browse/AMBARI-12906
>             Project: Ambari
>          Issue Type: Bug
>          Components: alerts
>    Affects Versions: 2.1.0
>            Reporter: Chandana Mirashi
>            Assignee: Qin Liu
>             Fix For: 2.4.0
>
>         Attachments: AMBARI-12906.patch
>
>
> User should not be allowed to save changes if the credential fields are left empty when creating new Alert Notifications.
> Steps to reproduce:
> 1. Create New Alert Notification
> 2. Enter Name = test
> 3. Tick the checkbox for 'Use Authentication'
> 4. Keep username and password empty
> 5. Click on Save
> 6. New alert notifications is created.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)