You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/07/19 08:29:32 UTC
[GitHub] vvraskin commented on a change in pull request #3876: Use separate
db users for deployed components.
vvraskin commented on a change in pull request #3876: Use separate db users for deployed components.
URL: https://github.com/apache/incubator-openwhisk/pull/3876#discussion_r203640925
##########
File path: ansible/roles/controller/tasks/deploy.yml
##########
@@ -162,8 +164,8 @@
"CONFIG_whisk_couchdb_protocol": "{{ db.protocol }}"
"CONFIG_whisk_couchdb_host": "{{ db.host }}"
"CONFIG_whisk_couchdb_port": "{{ db.port }}"
- "CONFIG_whisk_couchdb_username": "{{ db.credentials.admin.user }}"
- "CONFIG_whisk_couchdb_password": "{{ db.credentials.admin.pass }}"
+ "CONFIG_whisk_couchdb_username": "{{ db.credentials.controller.user }}"
Review comment:
should we perhaps use dbUser and dbPass here?
I think the same could be valid for the invoker as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services