You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/05/30 18:20:14 UTC

[GitHub] reminisce commented on a change in pull request #10889: [MXNET-382] Shape and Size Operator

reminisce commented on a change in pull request #10889: [MXNET-382] Shape and Size Operator
URL: https://github.com/apache/incubator-mxnet/pull/10889#discussion_r191868114
 
 

 ##########
 File path: src/operator/mshadow_op.h
 ##########
 @@ -96,6 +96,12 @@ struct identity_with_cast {
   }
 };
 
+struct size_kernel {
+  MSHADOW_XINLINE static void Map(int i, int64_t *out, unsigned int in) {
+    out[0] = int64_t(in);
 
 Review comment:
   nit: `static_cast<int64_t>`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services