You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ju...@apache.org on 2019/01/07 10:04:04 UTC
svn commit: r1850623 - in /subversion/branches/1.11.x: ./
subversion/mod_dav_svn/reports/list.c
Author: julianfoad
Date: Mon Jan 7 10:04:04 2019
New Revision: 1850623
URL: http://svn.apache.org/viewvc?rev=1850623&view=rev
Log:
Merge r1850621 from trunk:
* r1850621
Fix access to potentially uninitialized local pointer variable.
Votes:
+1: julianfoad, stsp, stefan2
Modified:
subversion/branches/1.11.x/ (props changed)
subversion/branches/1.11.x/subversion/mod_dav_svn/reports/list.c
Propchange: subversion/branches/1.11.x/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jan 7 10:04:04 2019
@@ -100,4 +100,4 @@
/subversion/branches/verify-at-commit:1462039-1462408
/subversion/branches/verify-keep-going:1439280-1546110
/subversion/branches/wc-collate-path:1402685-1480384
-/subversion/trunk:1840990-1840991,1840995,1840997,1841059,1841079,1841091,1841098,1841136,1841180,1841272,1841481,1841524-1841525,1841567,1841600-1841602,1841606,1841719,1841725,1841731,1841736,1841742-1841743,1841753-1841754,1841822,1841850,1841867,1842090,1842222-1842223,1842334,1842814,1842827,1842829,1842877,1843888,1844882,1844987,1845204,1845261,1845408,1845555-1845556,1845559,1845577,1846299,1846403,1846406,1846704,1847181-1847182,1847188,1847264,1847572,1847596,1850348
+/subversion/trunk:1840990-1840991,1840995,1840997,1841059,1841079,1841091,1841098,1841136,1841180,1841272,1841481,1841524-1841525,1841567,1841600-1841602,1841606,1841719,1841725,1841731,1841736,1841742-1841743,1841753-1841754,1841822,1841850,1841867,1842090,1842222-1842223,1842334,1842814,1842827,1842829,1842877,1843888,1844882,1844987,1845204,1845261,1845408,1845555-1845556,1845559,1845577,1846299,1846403,1846406,1846704,1847181-1847182,1847188,1847264,1847572,1847596,1850348,1850621
Modified: subversion/branches/1.11.x/subversion/mod_dav_svn/reports/list.c
URL: http://svn.apache.org/viewvc/subversion/branches/1.11.x/subversion/mod_dav_svn/reports/list.c?rev=1850623&r1=1850622&r2=1850623&view=diff
==============================================================================
--- subversion/branches/1.11.x/subversion/mod_dav_svn/reports/list.c (original)
+++ subversion/branches/1.11.x/subversion/mod_dav_svn/reports/list.c Mon Jan 7 10:04:04 2019
@@ -201,7 +201,7 @@ dav_svn__list_report(const dav_resource
dav_svn__authz_read_baton arb;
const dav_svn_repos *repos = resource->info->repos;
int ns;
- const char *full_path;
+ const char *full_path = NULL;
svn_boolean_t path_info_only;
svn_fs_root_t *root;
svn_depth_t depth = svn_depth_unknown;
@@ -280,6 +280,12 @@ dav_svn__list_report(const dav_resource
/* else unknown element; skip it */
}
+ if (! full_path)
+ {
+ return dav_svn__new_error_svn(resource->pool, HTTP_BAD_REQUEST, 0, 0,
+ "Request was missing the path argument");
+ }
+
/* Build authz read baton */
arb.r = resource->info->r;
arb.repos = resource->info->repos;