You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by aw...@gmail.com on 2009/06/09 20:03:13 UTC

Clean up error handling for proxy code

Reviewers: shindig.remailer_gmail.com,

Message:
A few small changes:
- move error handling out of "proxy" servlets and into the handlers
- handle invalid refresh params
- issue WARNING, not FINE or INFO if a GadgetException comes from an
internal server error (and send a 500, not a 400)




Please review this at http://codereview.appspot.com/63218

Affected files:
   M      
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ConcatProxyServlet.java
   M      
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
   M      
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestServlet.java
   M      
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyBase.java
   M      
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
   M      
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java
   M      
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java
   M      
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyBaseTest.java
   M      
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyHandlerTest.java