You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/26 02:45:31 UTC

[GitHub] [airflow] uranusjr commented on a change in pull request #21107: Return slack api call response in slack_hook

uranusjr commented on a change in pull request #21107:
URL: https://github.com/apache/airflow/pull/21107#discussion_r792277941



##########
File path: airflow/providers/slack/hooks/slack.py
##########
@@ -89,5 +90,9 @@ def call(self, api_method: str, **kwargs) -> None:
             form-encoding will take place. Optional.
         :param params: The URL parameters to append to the URL. Optional.
         :param json: JSON for the body to attach to the request. Optional.
+        :return: The server's response to an HTTP request. Data from the response can be
+            accessed like a dict.  If the response included 'next_cursor' it can be
+            iterated on to execute subsequent requests.
+        :rtype: SlackResponse

Review comment:
       ```suggestion
   ```
   
   Don’t need this since the return type is already visible in the function signature.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org