You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/06/03 22:15:13 UTC
[GitHub] [trafficserver] elsloo opened a new pull request #7920: Adds new X-Cache-Info header to the xdebug plugin (#7784)
elsloo opened a new pull request #7920:
URL: https://github.com/apache/trafficserver/pull/7920
This is a backport of changes made to the xdebug plugin via PR #7784 and it depends on backport PR #7919.
(cherry picked from commit 7433038df97229a056775de24008c2c7ef7b608f)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #7920: Adds new X-Cache-Info header to the xdebug plugin (#7784)
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #7920:
URL: https://github.com/apache/trafficserver/pull/7920#issuecomment-856969763
>
>
> It looks like #7783 will have to be backported to 9.1 before this?
yea that backport is in 7919, thats why it fails CI for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] elsloo commented on pull request #7920: Adds new X-Cache-Info header to the xdebug plugin (#7784)
Posted by GitBox <gi...@apache.org>.
elsloo commented on pull request #7920:
URL: https://github.com/apache/trafficserver/pull/7920#issuecomment-857011887
> > It looks like #7783 will have to be backported to 9.1 before this?
>
> yea that backport is in 7919, thats why it fails CI for now
Correct, however none of it really matters because @zwoop will likely cherry-pick these manually into 9.1.x, at which point, both of the PRs will be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] rob05c commented on pull request #7920: Adds new X-Cache-Info header to the xdebug plugin (#7784)
Posted by GitBox <gi...@apache.org>.
rob05c commented on pull request #7920:
URL: https://github.com/apache/trafficserver/pull/7920#issuecomment-854242694
I see this is a backport, I missed the original, sorry. But, the IETF has asked people not to use the `X-` prefix anymore.
Mostly because things tend to become standards, and then it's hard to remove the `X-`.
https://datatracker.ietf.org/doc/html/rfc6648
> Deprecating the "X-" Prefix and Similar Constructs
> in Application Protocols
Is it too late to change this to just `Cache-Info`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 edited a comment on pull request #7920: Adds new X-Cache-Info header to the xdebug plugin (#7784)
Posted by GitBox <gi...@apache.org>.
ezelkow1 edited a comment on pull request #7920:
URL: https://github.com/apache/trafficserver/pull/7920#issuecomment-854255888
I am +1 (once we get #7919 in so this builds). This is a debug plugin, its not adding actionable headers to the core but in an optional debug plugin that is also easily changed if somehow any of these become standards. Plus its a backport anyway and it already exists in the code base for future versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7920: Adds new X-Cache-Info header to the xdebug plugin (#7784)
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7920:
URL: https://github.com/apache/trafficserver/pull/7920#issuecomment-856968355
It looks like https://github.com/apache/trafficserver/pull/7783 will have to be backported to 9.1 before this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #7920: Adds new X-Cache-Info header to the xdebug plugin (#7784)
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #7920:
URL: https://github.com/apache/trafficserver/pull/7920#issuecomment-854255888
I am +1 (once we get #7917 in so this builds). This is a debug plugin, its not adding actionable headers to the core but in an optional debug plugin that is also easily changed if somehow any of these become standards. Plus its a backport anyway and it already exists in the code base for future versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] rob05c commented on pull request #7920: Adds new X-Cache-Info header to the xdebug plugin (#7784)
Posted by GitBox <gi...@apache.org>.
rob05c commented on pull request #7920:
URL: https://github.com/apache/trafficserver/pull/7920#issuecomment-854242694
I see this is a backport, I missed the original, sorry. But, the IETF has asked people not to use the `X-` prefix anymore.
Mostly because things tend to become standards, and then it's hard to remove the `X-`.
https://datatracker.ietf.org/doc/html/rfc6648
> Deprecating the "X-" Prefix and Similar Constructs
> in Application Protocols
Is it too late to change this to just `Cache-Info`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7920: Adds new X-Cache-Info header to the xdebug plugin (#7784)
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7920:
URL: https://github.com/apache/trafficserver/pull/7920#issuecomment-857026180
I think then the project for https://github.com/apache/trafficserver/pull/7783 needs to be changed to 9.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] elsloo commented on pull request #7920: Adds new X-Cache-Info header to the xdebug plugin (#7784)
Posted by GitBox <gi...@apache.org>.
elsloo commented on pull request #7920:
URL: https://github.com/apache/trafficserver/pull/7920#issuecomment-854253426
> I see this is a backport, I missed the original, sorry. But, the IETF has asked people not to use the `X-` prefix anymore.
>
> Mostly because things tend to become standards, and then it's hard to remove the `X-`.
>
> https://datatracker.ietf.org/doc/html/rfc6648
>
> > Deprecating the "X-" Prefix and Similar Constructs
> > in Application Protocols
Yes, I'm aware of this and chose consistency over following the best practice you referenced. `X` is used throughout the plugin, the headers, and its name. Having a single header without the prefix would lead to a less intuitive experience when using this plugin.
> Is it too late to change this to just `Cache-Info`?
IMO, yes, this is a backport as you noted above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] elsloo commented on pull request #7920: Adds new X-Cache-Info header to the xdebug plugin (#7784)
Posted by GitBox <gi...@apache.org>.
elsloo commented on pull request #7920:
URL: https://github.com/apache/trafficserver/pull/7920#issuecomment-854253426
> I see this is a backport, I missed the original, sorry. But, the IETF has asked people not to use the `X-` prefix anymore.
>
> Mostly because things tend to become standards, and then it's hard to remove the `X-`.
>
> https://datatracker.ietf.org/doc/html/rfc6648
>
> > Deprecating the "X-" Prefix and Similar Constructs
> > in Application Protocols
Yes, I'm aware of this and chose consistency over following the best practice you referenced. `X` is used throughout the plugin, the headers, and its name. Having a single header without the prefix would lead to a less intuitive experience when using this plugin.
> Is it too late to change this to just `Cache-Info`?
IMO, yes, this is a backport as you noted above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #7920: Adds new X-Cache-Info header to the xdebug plugin (#7784)
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #7920:
URL: https://github.com/apache/trafficserver/pull/7920#issuecomment-854255888
I am +1 (once we get #7917 in so this builds). This is a debug plugin, its not adding actionable headers to the core but in an optional debug plugin that is also easily changed if somehow any of these become standards. Plus its a backport anyway and it already exists in the code base for future versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org