You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/25 01:03:25 UTC
Review Request 67303: Added documentation for resource provider and
CSI plugin metrics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67303/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Greg Mann, and Jie Yu.
Repository: mesos
Description
-------
Added documentation for resource provider and CSI plugin metrics.
Diffs
-----
docs/home.md 5471c70d4023f88adae2234aec267e4d6fea83df
docs/monitoring.md c20b99eb32a50830ea6f66b5bdbfcabe45fc6ecb
Diff: https://reviews.apache.org/r/67303/diff/1/
Testing
-------
Spell checked through VIM's `:set spell` and manually tested the links.
Thanks,
Chun-Hung Hsiao
Re: Review Request 67303: Added documentation for resource provider
and CSI plugin metrics.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67303/#review203837
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65665', '65666', '67224', '67255', '67256', '67257', '67258', '67303']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67303
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67303/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (107 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (995 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (34 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (38 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (73 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (794 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (819 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (728 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (752 ms total)
[----------] Global test environment tear-down
[==========] 980 tests from 95 test cases ran. (437014 ms total)
[ PASSED ] 979 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerContainerizerHealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
1 FAILED TEST
YOU HAVE 220 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67303/logs/mesos-tests-stderr.log):
```
I0525 01:56:45.183856 13092 master.cpp:I0525 01:56:45.025862 16336 exec.cpp:162] Version: 1.7.0
I0525 01:56:45.049860 19988 exec.cpp:236] Executor registered on agent 30130cad-c3ad-4171-868f-2b49173604ae-S0
I0525 01:56:45.053845 13068 executor.cpp:178] Received SUBSCRIBED event
I0525 01:56:45.058856 13068 executor.cpp:182] Subscribed executor on windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0525 01:56:45.058856 13068 executor.cpp:178] Received LAUNCH event
I0525 01:56:45.063856 13068 executor.cpp:665] Starting task 40436c90-fb27-44ff-8b6b-686f2f996cf9
I0525 01:56:45.139863 13068 executor.cpp:485] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0525 01:56:45.155863 13068 executor.cpp:678] Forked command at 22672
I0525 01:56:45.186859 17220 exec.cpp:445] Executor asked to shutdown
I0525 01:56:45.186859 9032 executor.cpp:178] Received SHUTDOWN event
I0525 01:56:45.186859 9032 executor.cpp:781] Shutting down
I0525 01:56:45.186859 9032 executor.cpp:894] Sending SIGTERM to process tree at pid 2210843] Updating the state of task 40436c90-fb27-44ff-8b6b-686f2f996cf9 of framework 30130cad-c3ad-4171-868f-2b49173604ae-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0525 01:56:45.183856 19620 slave.cpp:3935] Shutting down framework 30130cad-c3ad-4171-868f-2b49173604ae-0000
I0525 01:56:45.184849 19620 slave.cpp:6656] Shutting down executor '40436c90-fb27-44ff-8b6b-686f2f996cf9' of framework 30130cad-c3ad-4171-868f-2b49173604ae-0000 at executor(1)@192.10.1.6:58813
I0525 01:56:45.186859 19620 slave.cpp:929] Agent terminating
W0525 01:56:45.186859 19620 slave.cpp:3931] Ignoring shutdown framework 30130cad-c3ad-4171-868f-2b49173604ae-0000 because it is terminating
I0525 01:56:45.187857 13092 master.cpp:10942] Removing task 40436c90-fb27-44ff-8b6b-686f2f996cf9 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 30130cad-c3ad-4171-868f-2b49173604ae-0000 on agent 30130cad-c3ad-4171-868f-2b49173604ae-S0 at slave(447)@192.10.1.6:58792 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0525 01:56:45.190850 13092 master.cpp:1293] Agent 30130cad-c3ad-4171-868f-2b49173604ae-S0 at slave(447)@192.10.1.6:58792 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0525 01:56:45.190850 13092 master.cpp:3303] Disconnecting agent 30130cad-c3ad-4171-868f-2b49173604ae-S0 at slave(447)@192.10.1.6:58792 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0525 01:56:45.190850 18504 containerizer.cpp:2401] Destroying container d556b800-bf54-418f-9b29-d43798d86c9a in RUNNING state
I0525 01:56:45.190850 19620 hierarchical.cpp:344] Removed framework 30130cad-c3ad-4171-868f-2b49173604ae-0000
I0525 01:56:45.190850 13092 master.cpp:3322] Deactivating agent 30130cad-c3ad-4171-868f-2b49173604ae-S0 at slave(447)@192.10.1.6:58792 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0525 01:56:45.190850 18504 containerizer.cpp:3015] Transitioning the state of container d556b800-bf54-418f-9b29-d43798d86c9a from RUNNING to DESTROYING
I0525 01:56:45.191850 15652 hierarchical.cpp:766] Agent 30130cad-c3ad-4171-868f-2b49173604ae-S0 deactivated
I0525 01:56:45.192857 18504 launcher.cpp:156] Asked to destroy container d556b800-bf54-418f-9b29-d43798d86c9a
I0525 01:56:45.238589 8608 containerizer.cpp:2854] Container d556b800-bf54-418f-9b29-d43798d86c9a has exited
I0525 01:56:45.268565 6120 master.cpp:1135] Master terminating
I0525 01:56:45.270586 22600 hierarchical.cpp:609] Removed agent 30130cad-c3ad-4171-868f-2b49173604ae-S0
I0525 01:56:45.737602 20568 process.cpp:940] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On May 25, 2018, 1:05 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67303/
> -----------------------------------------------------------
>
> (Updated May 25, 2018, 1:05 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for resource provider and CSI plugin metrics.
>
>
> Diffs
> -----
>
> docs/home.md 5471c70d4023f88adae2234aec267e4d6fea83df
> docs/monitoring.md c20b99eb32a50830ea6f66b5bdbfcabe45fc6ecb
>
>
> Diff: https://reviews.apache.org/r/67303/diff/2/
>
>
> Testing
> -------
>
> Spell checked through VIM's `:set spell` and manually tested the links.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 67303: Added documentation for resource provider
and CSI plugin metrics.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67303/
-----------------------------------------------------------
(Updated May 31, 2018, 11:08 p.m.)
Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Joerg Schad.
Changes
-------
Addressed Jie's comments.
Repository: mesos
Description
-------
Added documentation for resource provider and CSI plugin metrics.
Diffs (updated)
-----
docs/home.md 5471c70d4023f88adae2234aec267e4d6fea83df
docs/monitoring.md c20b99eb32a50830ea6f66b5bdbfcabe45fc6ecb
Diff: https://reviews.apache.org/r/67303/diff/4/
Changes: https://reviews.apache.org/r/67303/diff/3-4/
Testing
-------
Spell checked through VIM's `:set spell` and manually tested the links.
Thanks,
Chun-Hung Hsiao
Re: Review Request 67303: Added documentation for resource provider
and CSI plugin metrics.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67303/#review204156
-----------------------------------------------------------
Fix it, then Ship it!
Thanks!
docs/monitoring.md
Lines 1771 (patched)
<https://reviews.apache.org/r/67303/#comment286543>
"that apply to the resources provided by a resource provider with the given type and name"
docs/monitoring.md
Lines 1813 (patched)
<https://reviews.apache.org/r/67303/#comment286544>
may vary
docs/monitoring.md
Lines 1814-1816 (patched)
<https://reviews.apache.org/r/67303/#comment286545>
the following is a comprehensive list of operation types and the corresponding resource providers that support them. Note that the name column is for the operation placeholder in the above metrics.
- Jie Yu
On May 25, 2018, 6:30 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67303/
> -----------------------------------------------------------
>
> (Updated May 25, 2018, 6:30 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Joerg Schad.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for resource provider and CSI plugin metrics.
>
>
> Diffs
> -----
>
> docs/home.md 5471c70d4023f88adae2234aec267e4d6fea83df
> docs/monitoring.md c20b99eb32a50830ea6f66b5bdbfcabe45fc6ecb
>
>
> Diff: https://reviews.apache.org/r/67303/diff/3/
>
>
> Testing
> -------
>
> Spell checked through VIM's `:set spell` and manually tested the links.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 67303: Added documentation for resource provider
and CSI plugin metrics.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67303/
-----------------------------------------------------------
(Updated May 25, 2018, 6:30 p.m.)
Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Joerg Schad.
Changes
-------
Quoted placeholders with angle brackets in metrics.
Repository: mesos
Description
-------
Added documentation for resource provider and CSI plugin metrics.
Diffs (updated)
-----
docs/home.md 5471c70d4023f88adae2234aec267e4d6fea83df
docs/monitoring.md c20b99eb32a50830ea6f66b5bdbfcabe45fc6ecb
Diff: https://reviews.apache.org/r/67303/diff/3/
Changes: https://reviews.apache.org/r/67303/diff/2-3/
Testing
-------
Spell checked through VIM's `:set spell` and manually tested the links.
Thanks,
Chun-Hung Hsiao
Re: Review Request 67303: Added documentation for resource provider
and CSI plugin metrics.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67303/
-----------------------------------------------------------
(Updated May 25, 2018, 1:05 a.m.)
Review request for mesos, Benjamin Bannier, Greg Mann, and Jie Yu.
Changes
-------
Fixed a link to `resource-provider.md` (which is still not existed yet).
Repository: mesos
Description
-------
Added documentation for resource provider and CSI plugin metrics.
Diffs (updated)
-----
docs/home.md 5471c70d4023f88adae2234aec267e4d6fea83df
docs/monitoring.md c20b99eb32a50830ea6f66b5bdbfcabe45fc6ecb
Diff: https://reviews.apache.org/r/67303/diff/2/
Changes: https://reviews.apache.org/r/67303/diff/1-2/
Testing
-------
Spell checked through VIM's `:set spell` and manually tested the links.
Thanks,
Chun-Hung Hsiao