You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by syedhashmi <gi...@git.apache.org> on 2014/05/10 07:14:46 UTC
[GitHub] spark pull request: [SPARK-1784] Add a new partitioner
GitHub user syedhashmi opened a pull request:
https://github.com/apache/spark/pull/721
[SPARK-1784] Add a new partitioner
This change adds a new partitioner which allows users
to specify # of keys per partition.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/syedhashmi/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/721.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #721
----
commit 4ca94cc155aea4be36505d5f37d037e209078196
Author: Syed Hashmi <sh...@cloudera.com>
Date: 2014-05-09T23:32:32Z
[SPARK-1784] Add a new partitioner
This change adds a new partitioner which allows users
to specify # of keys per partition.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1784] Add a new partitioner to allow sp...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/721#issuecomment-43046369
This was merged by mistake by @rxin (I just spoke with him). I am going to revert this. Unfortunately it also broke the master build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1784] Add a new partitioner to allow sp...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/721#issuecomment-43046623
Thanks for doing this.
On Tuesday, May 13, 2014, Patrick Wendell <no...@github.com> wrote:
> @rxin <https://github.com/rxin> merged this in lieu of #729<https://github.com/apache/spark/pull/729>- so I'm going to merge that one now.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/apache/spark/pull/721#issuecomment-43046527>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1784] Add a new partitioner to allow sp...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/721#issuecomment-43046094
Oh interestingly we were just having a side conversation about this.
Is it going to be an issue that the partitioner does not consistently assign the same key to the same partition? I didn't think this would work. The assignments entirely local to the instance of the partitioner. Does this not also maybe yield different result in a multi-threaded context, even with the same input?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1784] Add a new partitioner
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/721#issuecomment-42732136
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1784] Add a new partitioner to allow sp...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/721
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1784] Add a new partitioner to allow sp...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/721#issuecomment-43046527
@rxin merged this in lieu of #729 - so I'm going to merge that one now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---