You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by chipitsine <gi...@git.apache.org> on 2017/09/24 15:19:16 UTC
[GitHub] incubator-guacamole-client pull request #188: GUACAMOLE-392: add basic travi...
GitHub user chipitsine opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/188
GUACAMOLE-392: add basic travis-ci integration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chipitsine/incubator-guacamole-client travis-ci
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/188.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #188
----
commit 41e04e0f12f155e9fc29ae39ec1889d3b93f2a48
Author: Ilya Shipitsin <ch...@gmail.com>
Date: 2017-09-24T15:18:05Z
GUACAMOLE-392: add basic travis-ci integration
----
---
[GitHub] incubator-guacamole-client pull request #188: GUACAMOLE-392: add basic travi...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/188#discussion_r140661789
--- Diff: .travis.yml ---
@@ -0,0 +1,14 @@
+dist: trusty
+
+os: linux
+
+install: true
+
+cache:
+ directories: [ $HOME/.m2 ]
+
+language: java
+
+script:
+ - mvn install -DskipTests=true -Drat.skip=true -Dmaven.javadoc.skip=true -B -V
--- End diff --
As with apache/incubator-guacamole-server#110, I'm not confident Travis CI is a good choice. Depending on the result of discussion, if we do choose to go with Travis, skipping parts of the build shouldn't be done, especially tests and the RAT check. Catching test failures is one of the key points of using CI.
---
[GitHub] incubator-guacamole-client pull request #188: GUACAMOLE-392: add basic travi...
Posted by chipitsine <gi...@git.apache.org>.
Github user chipitsine commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/188#discussion_r147548262
--- Diff: .travis.yml ---
@@ -0,0 +1,14 @@
+dist: trusty
+
+os: linux
+
+install: true
+
+cache:
+ directories: [ $HOME/.m2 ]
+
+language: java
+
+script:
+ - mvn install -DskipTests=true -Drat.skip=true -Dmaven.javadoc.skip=true -B -V
--- End diff --
as for skipping RAT check, I left that to those who understands how to deal with that :) I do not insist in skipping actually
---