You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/03/27 18:39:16 UTC
[GitHub] [druid] himanshug commented on a change in pull request #9568: fix
MAX_INTERMEDIATE_SIZE for DoubleMeanHolder
himanshug commented on a change in pull request #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder
URL: https://github.com/apache/druid/pull/9568#discussion_r399467859
##########
File path: processing/src/main/java/org/apache/druid/query/aggregation/mean/DoubleMeanAggregatorFactory.java
##########
@@ -152,6 +152,8 @@ public Object deserialize(Object object)
return DoubleMeanHolder.fromBytes(StringUtils.decodeBase64(StringUtils.toUtf8((String) object)));
} else if (object instanceof DoubleMeanHolder) {
return object;
+ } else if (object instanceof byte[]) {
Review comment:
can we make byte[] be the firs if check in both places ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org