[myfaces-tobago] branch master updated: TOBAGO-1897 Tooltip for badge component

[hn...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

hnoeth pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git


The following commit(s) were added to refs/heads/master by this push:
     new 62127aa  TOBAGO-1897 Tooltip for badge component
62127aa is described below

commit 62127aa9402e60f7223d5f696f97f0da646557f6
Author: Henning Noeth <hn...@apache.org>
AuthorDate: Mon Jul 30 14:16:28 2018 +0200

    TOBAGO-1897 Tooltip for badge component
    
    * 'tip' attribute added for tc:badge
    (tc:button markup="badge" already have a 'tip' attribute)
---
 .../apache/myfaces/tobago/internal/component/AbstractUIBadge.java    | 1 +
 .../myfaces/tobago/internal/renderkit/renderer/BadgeRenderer.java    | 5 +++++
 .../tobago/internal/taglib/component/BadgeTagDeclaration.java        | 3 ++-
 3 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIBadge.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIBadge.java
index 8b436fd..ad447a7 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIBadge.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIBadge.java
@@ -25,4 +25,5 @@ import javax.faces.component.UIOutput;
 
 public abstract class AbstractUIBadge extends UIOutput implements Visual {
 
+  public abstract String getTip();
 }
diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/BadgeRenderer.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/BadgeRenderer.java
index b66afa5..7ccd331 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/BadgeRenderer.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/BadgeRenderer.java
@@ -26,6 +26,7 @@ import org.apache.myfaces.tobago.renderkit.RendererBase;
 import org.apache.myfaces.tobago.renderkit.css.BootstrapClass;
 import org.apache.myfaces.tobago.renderkit.css.CssItem;
 import org.apache.myfaces.tobago.renderkit.css.TobagoClass;
+import org.apache.myfaces.tobago.renderkit.html.HtmlAttributes;
 import org.apache.myfaces.tobago.renderkit.html.HtmlElements;
 import org.apache.myfaces.tobago.webapp.TobagoResponseWriter;
 
@@ -40,6 +41,7 @@ public class BadgeRenderer extends RendererBase {
     final TobagoResponseWriter writer = getResponseWriter(facesContext);
     final AbstractUIBadge badge = (AbstractUIBadge) component;
     final Markup markup = badge.getMarkup() != null ? badge.getMarkup() : Markup.NULL;
+    final String tip = badge.getTip();
     final String value = RenderUtils.currentValue(badge);
 
     writer.startElement(HtmlElements.SPAN);
@@ -53,6 +55,9 @@ public class BadgeRenderer extends RendererBase {
         getAdditionalCssItem(),
         badge.getCustomClass());
 
+    if (tip != null) {
+      writer.writeAttribute(HtmlAttributes.TITLE, tip, true);
+    }
     if (value != null) {
       writer.writeText(value);
     }
diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/BadgeTagDeclaration.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/BadgeTagDeclaration.java
index adb5b21..f41acec 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/BadgeTagDeclaration.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/BadgeTagDeclaration.java
@@ -24,6 +24,7 @@ import org.apache.myfaces.tobago.apt.annotation.Tag;
 import org.apache.myfaces.tobago.apt.annotation.UIComponentTag;
 import org.apache.myfaces.tobago.component.RendererTypes;
 import org.apache.myfaces.tobago.internal.taglib.declaration.HasIdBindingAndRendered;
+import org.apache.myfaces.tobago.internal.taglib.declaration.HasTip;
 import org.apache.myfaces.tobago.internal.taglib.declaration.HasValue;
 import org.apache.myfaces.tobago.internal.taglib.declaration.IsVisual;
 
@@ -86,5 +87,5 @@ import javax.faces.component.UIOutput;
             description = "Colorless badge."
         )
     })
-public interface BadgeTagDeclaration extends HasIdBindingAndRendered, IsVisual, HasValue {
+public interface BadgeTagDeclaration extends HasIdBindingAndRendered, HasTip, IsVisual, HasValue {
 }