You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@answer.apache.org by "sy-records (via GitHub)" <gi...@apache.org> on 2023/10/26 10:16:49 UTC
[PR] update: navigation and footer [incubator-answer-website]
sy-records opened a new pull request, #109:
URL: https://github.com/apache/incubator-answer-website/pull/109
#107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update: navigation and footer [incubator-answer-website]
Posted by "shuashuai (via GitHub)" <gi...@apache.org>.
shuashuai commented on code in PR #109:
URL: https://github.com/apache/incubator-answer-website/pull/109#discussion_r1374025290
##########
docusaurus.config.js:
##########
Review Comment:
It doesn't seem to remove the reference to katex completely, you can remove the rehype-katex dependency by the way in package.json and then remove the reference to katex in docusaurus.config.js


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update: navigation and footer [incubator-answer-website]
Posted by "sy-records (via GitHub)" <gi...@apache.org>.
sy-records commented on code in PR #109:
URL: https://github.com/apache/incubator-answer-website/pull/109#discussion_r1374022418
##########
docusaurus.config.js:
##########
@@ -4,6 +4,16 @@ const lightCodeTheme = require('prism-react-renderer/themes/github');
const darkCodeTheme = require('prism-react-renderer/themes/dracula');
const math = require('remark-math');
const katex = require('rehype-katex');
Review Comment:
Does `rehype-katex` need to be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update: navigation and footer [incubator-answer-website]
Posted by "fenbox (via GitHub)" <gi...@apache.org>.
fenbox commented on code in PR #109:
URL: https://github.com/apache/incubator-answer-website/pull/109#discussion_r1372948985
##########
src/theme/Footer/index.tsx:
##########
@@ -1,78 +1,37 @@
import React, { FC } from 'react';
-const DarkSvg = require('@site/static/img/logo-dark.svg').default;
+const ApacheSvg = require('@site/static/img/apache/incubator.svg').default;
const Footer: FC = () => {
return (
<footer className="footer">
<div className="container py-3">
- <div className="d-flex justify-content-between flex-wrap">
+ <div className="d-flex justify-content-between flex-wrap text-center">
<div>
- <div className='mb-3' style={{ height: '28px' }}>
- <DarkSvg role="img" />
+ <div className='mb-3'>
+ <ApacheSvg role="img" />
</div>
- {/* <img src={require('@site/static/img/logo-dark.svg').default} alt="" height="28" /> */}
+
<div className="fs-14">
<div>
- <span>Made with love in the world by the</span>{' '}
- <a
- href="https://github.com/orgs/answerdev/people"
- target="_blank"
- >
- Answer team
- </a>
- <span> with the help of </span>
- <a
- href="https://github.com/apache/incubator-answer/graphs/contributors"
- target="_blank"
- >
- our contributors
- </a>
- .
+ <span>Apache Answer is an effort undergoing incubation at The Apache Software Foundation (ASF), sponsored by the Apache Incubator. Incubation is required of all newly accepted projects until a further review indicates that the infrastructure, communications, and decision making process have stabilized in a manner consistent with other successful ASF projects. While incubation status is not necessarily a reflection of the completeness or stability of the code, it does indicate that the project has yet to be fully endorsed by the ASF.</span>
+ </div>
+
+ <div style={{marginTop: '10px', marginBottom: '10px'}}>
Review Comment:
use bootstrap default class such as `my-3` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update: navigation and footer [incubator-answer-website]
Posted by "fenbox (via GitHub)" <gi...@apache.org>.
fenbox commented on code in PR #109:
URL: https://github.com/apache/incubator-answer-website/pull/109#discussion_r1372948985
##########
src/theme/Footer/index.tsx:
##########
@@ -1,78 +1,37 @@
import React, { FC } from 'react';
-const DarkSvg = require('@site/static/img/logo-dark.svg').default;
+const ApacheSvg = require('@site/static/img/apache/incubator.svg').default;
const Footer: FC = () => {
return (
<footer className="footer">
<div className="container py-3">
- <div className="d-flex justify-content-between flex-wrap">
+ <div className="d-flex justify-content-between flex-wrap text-center">
<div>
- <div className='mb-3' style={{ height: '28px' }}>
- <DarkSvg role="img" />
+ <div className='mb-3'>
+ <ApacheSvg role="img" />
</div>
- {/* <img src={require('@site/static/img/logo-dark.svg').default} alt="" height="28" /> */}
+
<div className="fs-14">
<div>
- <span>Made with love in the world by the</span>{' '}
- <a
- href="https://github.com/orgs/answerdev/people"
- target="_blank"
- >
- Answer team
- </a>
- <span> with the help of </span>
- <a
- href="https://github.com/apache/incubator-answer/graphs/contributors"
- target="_blank"
- >
- our contributors
- </a>
- .
+ <span>Apache Answer is an effort undergoing incubation at The Apache Software Foundation (ASF), sponsored by the Apache Incubator. Incubation is required of all newly accepted projects until a further review indicates that the infrastructure, communications, and decision making process have stabilized in a manner consistent with other successful ASF projects. While incubation status is not necessarily a reflection of the completeness or stability of the code, it does indicate that the project has yet to be fully endorsed by the ASF.</span>
+ </div>
+
+ <div style={{marginTop: '10px', marginBottom: '10px'}}>
Review Comment:
use bootstrap default class such as `my-3` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update: navigation and footer [incubator-answer-website]
Posted by "fenbox (via GitHub)" <gi...@apache.org>.
fenbox commented on code in PR #109:
URL: https://github.com/apache/incubator-answer-website/pull/109#discussion_r1372948985
##########
src/theme/Footer/index.tsx:
##########
@@ -1,78 +1,37 @@
import React, { FC } from 'react';
-const DarkSvg = require('@site/static/img/logo-dark.svg').default;
+const ApacheSvg = require('@site/static/img/apache/incubator.svg').default;
const Footer: FC = () => {
return (
<footer className="footer">
<div className="container py-3">
- <div className="d-flex justify-content-between flex-wrap">
+ <div className="d-flex justify-content-between flex-wrap text-center">
<div>
- <div className='mb-3' style={{ height: '28px' }}>
- <DarkSvg role="img" />
+ <div className='mb-3'>
+ <ApacheSvg role="img" />
</div>
- {/* <img src={require('@site/static/img/logo-dark.svg').default} alt="" height="28" /> */}
+
<div className="fs-14">
<div>
- <span>Made with love in the world by the</span>{' '}
- <a
- href="https://github.com/orgs/answerdev/people"
- target="_blank"
- >
- Answer team
- </a>
- <span> with the help of </span>
- <a
- href="https://github.com/apache/incubator-answer/graphs/contributors"
- target="_blank"
- >
- our contributors
- </a>
- .
+ <span>Apache Answer is an effort undergoing incubation at The Apache Software Foundation (ASF), sponsored by the Apache Incubator. Incubation is required of all newly accepted projects until a further review indicates that the infrastructure, communications, and decision making process have stabilized in a manner consistent with other successful ASF projects. While incubation status is not necessarily a reflection of the completeness or stability of the code, it does indicate that the project has yet to be fully endorsed by the ASF.</span>
+ </div>
+
+ <div style={{marginTop: '10px', marginBottom: '10px'}}>
Review Comment:
use bootstrap default class such as `py-3` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update: navigation and footer [incubator-answer-website]
Posted by "fenbox (via GitHub)" <gi...@apache.org>.
fenbox commented on code in PR #109:
URL: https://github.com/apache/incubator-answer-website/pull/109#discussion_r1372951740
##########
src/theme/Footer/index.tsx:
##########
@@ -1,78 +1,37 @@
import React, { FC } from 'react';
-const DarkSvg = require('@site/static/img/logo-dark.svg').default;
+const ApacheSvg = require('@site/static/img/apache/incubator.svg').default;
const Footer: FC = () => {
return (
<footer className="footer">
<div className="container py-3">
- <div className="d-flex justify-content-between flex-wrap">
+ <div className="d-flex justify-content-between flex-wrap text-center">
<div>
- <div className='mb-3' style={{ height: '28px' }}>
- <DarkSvg role="img" />
+ <div className='mb-3'>
+ <ApacheSvg role="img" />
</div>
- {/* <img src={require('@site/static/img/logo-dark.svg').default} alt="" height="28" /> */}
+
<div className="fs-14">
<div>
- <span>Made with love in the world by the</span>{' '}
- <a
- href="https://github.com/orgs/answerdev/people"
- target="_blank"
- >
- Answer team
- </a>
- <span> with the help of </span>
- <a
- href="https://github.com/apache/incubator-answer/graphs/contributors"
- target="_blank"
- >
- our contributors
- </a>
- .
+ <span>Apache Answer is an effort undergoing incubation at The Apache Software Foundation (ASF), sponsored by the Apache Incubator. Incubation is required of all newly accepted projects until a further review indicates that the infrastructure, communications, and decision making process have stabilized in a manner consistent with other successful ASF projects. While incubation status is not necessarily a reflection of the completeness or stability of the code, it does indicate that the project has yet to be fully endorsed by the ASF.</span>
+ </div>
+
+ <div style={{marginTop: '10px', marginBottom: '10px'}}>
Review Comment:
use bootstrap default space class such as `my-3` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update: navigation and footer [incubator-answer-website]
Posted by "shuashuai (via GitHub)" <gi...@apache.org>.
shuashuai commented on code in PR #109:
URL: https://github.com/apache/incubator-answer-website/pull/109#discussion_r1374026991
##########
docusaurus.config.js:
##########
@@ -4,6 +4,16 @@ const lightCodeTheme = require('prism-react-renderer/themes/github');
const darkCodeTheme = require('prism-react-renderer/themes/dracula');
const math = require('remark-math');
const katex = require('rehype-katex');
Review Comment:
Of course, you can remove the dependencies of rehype-katex by the way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update: navigation and footer [incubator-answer-website]
Posted by "shuashuai (via GitHub)" <gi...@apache.org>.
shuashuai merged PR #109:
URL: https://github.com/apache/incubator-answer-website/pull/109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update: navigation and footer [incubator-answer-website]
Posted by "fenbox (via GitHub)" <gi...@apache.org>.
fenbox commented on code in PR #109:
URL: https://github.com/apache/incubator-answer-website/pull/109#discussion_r1372952838
##########
src/theme/Footer/index.tsx:
##########
@@ -1,78 +1,37 @@
import React, { FC } from 'react';
-const DarkSvg = require('@site/static/img/logo-dark.svg').default;
+const ApacheSvg = require('@site/static/img/apache/incubator.svg').default;
const Footer: FC = () => {
return (
<footer className="footer">
<div className="container py-3">
- <div className="d-flex justify-content-between flex-wrap">
+ <div className="d-flex justify-content-between flex-wrap text-center">
<div>
- <div className='mb-3' style={{ height: '28px' }}>
- <DarkSvg role="img" />
+ <div className='mb-3'>
+ <ApacheSvg role="img" />
Review Comment:
logo need link to https://incubator.apache.org/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update: navigation and footer [incubator-answer-website]
Posted by "sy-records (via GitHub)" <gi...@apache.org>.
sy-records commented on code in PR #109:
URL: https://github.com/apache/incubator-answer-website/pull/109#discussion_r1374027294
##########
docusaurus.config.js:
##########
@@ -4,6 +4,16 @@ const lightCodeTheme = require('prism-react-renderer/themes/github');
const darkCodeTheme = require('prism-react-renderer/themes/dracula');
const math = require('remark-math');
const katex = require('rehype-katex');
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org