[GitHub] [spark] amaliujia edited a comment on pull request #35472: [SPARK-38170][TESTS][SQL] Make ThriftServerWithSparkContextInHttpSuite pass with ANSI enabled

[GitBox <gi...@apache.org>]

amaliujia edited a comment on pull request #35472:
URL: https://github.com/apache/spark/pull/35472#issuecomment-1035920384


   > @amaliujia I just tried running the failed test. I think it would be better to change to query instead, e.g
   > 
   > ```
   > select abs(date'2021-01-1')
   > ```
   > 
   > This query throws the same exception with/without ANSI mode on.
   
   I see. Interesting. So the goal is to avoid issues brought by enabling ANSI mode on such non-core tests (thus changing query is ok). If so then the change will be easier to make.
   
   
   > Also, it would be better to combine the fix of one or two more test suites together in one PR.
   
   If we can change queries on Thrift server related tests, then combing multiple fixes into one PR wouldn't too bad.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org