You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by le...@apache.org on 2022/04/21 20:56:13 UTC
[datasketches-java] branch Final_cleanup_prior_to_release created (now a8ec6e05)
This is an automated email from the ASF dual-hosted git repository.
leerho pushed a change to branch Final_cleanup_prior_to_release
in repository https://gitbox.apache.org/repos/asf/datasketches-java.git
at a8ec6e05 Updated TestNG to 7.5. Removed unnecessary SuppressWarnings. NO CODE CHANGES
This branch includes the following new commits:
new a8ec6e05 Updated TestNG to 7.5. Removed unnecessary SuppressWarnings. NO CODE CHANGES
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[datasketches-java] 01/01: Updated TestNG to 7.5. Removed unnecessary SuppressWarnings. NO CODE CHANGES
Posted by le...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
leerho pushed a commit to branch Final_cleanup_prior_to_release
in repository https://gitbox.apache.org/repos/asf/datasketches-java.git
commit a8ec6e0514b6a28ede6f2713e9afe50f34d06293
Author: Lee Rhodes <le...@users.noreply.github.com>
AuthorDate: Thu Apr 21 13:52:51 2022 -0700
Updated TestNG to 7.5. Removed unnecessary SuppressWarnings. NO CODE
CHANGES
---
pom.xml | 4 ++--
src/main/java/org/apache/datasketches/fdt/FdtSketch.java | 1 -
src/main/java/org/apache/datasketches/kll/KllHelper.java | 2 --
.../java/org/apache/datasketches/kll/KllDirectDoublesSketchTest.java | 1 -
.../java/org/apache/datasketches/kll/KllDirectFloatsSketchTest.java | 1 -
src/test/java/org/apache/datasketches/kll/KllDoublesSketchTest.java | 3 ---
.../java/org/apache/datasketches/kll/KllDoublesValidationTest.java | 2 +-
src/test/java/org/apache/datasketches/kll/KllFloatsSketchTest.java | 3 ---
.../java/org/apache/datasketches/kll/KllFloatsValidationTest.java | 2 +-
src/test/java/org/apache/datasketches/kll/MiscDoublesTest.java | 1 -
src/test/java/org/apache/datasketches/kll/MiscFloatsTest.java | 1 -
11 files changed, 4 insertions(+), 17 deletions(-)
diff --git a/pom.xml b/pom.xml
index 6871667d..706d364e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -88,7 +88,7 @@ under the License.
<!-- END:UNIQUE FOR THIS JAVA COMPONENT -->
<!-- Test -->
- <testng.version>7.4.0</testng.version>
+ <testng.version>7.5</testng.version>
<!-- System-wide properties -->
<maven.version>3.5.0</maven.version>
@@ -103,7 +103,7 @@ under the License.
<!-- org.codehaus plugins -->
<!-- used for strict profile testing-->
- <plexus-compiler-javac-errorprone.version>2.8.5</plexus-compiler-javac-errorprone.version>
+ <plexus-compiler-javac-errorprone.version>2.11.1</plexus-compiler-javac-errorprone.version>
<versions-maven-plugin.version>2.8.1</versions-maven-plugin.version>
<!-- Maven Plugins -->
diff --git a/src/main/java/org/apache/datasketches/fdt/FdtSketch.java b/src/main/java/org/apache/datasketches/fdt/FdtSketch.java
index 4b4617e8..79e51a97 100644
--- a/src/main/java/org/apache/datasketches/fdt/FdtSketch.java
+++ b/src/main/java/org/apache/datasketches/fdt/FdtSketch.java
@@ -93,7 +93,6 @@ public class FdtSketch extends ArrayOfStringsSketch {
/**
* @return a deep copy of this sketch
*/
- @SuppressWarnings("unchecked")
@Override
public FdtSketch copy() {
return new FdtSketch(this);
diff --git a/src/main/java/org/apache/datasketches/kll/KllHelper.java b/src/main/java/org/apache/datasketches/kll/KllHelper.java
index dfbcdf7a..5655296a 100644
--- a/src/main/java/org/apache/datasketches/kll/KllHelper.java
+++ b/src/main/java/org/apache/datasketches/kll/KllHelper.java
@@ -622,7 +622,6 @@ final class KllHelper {
return byteArr;
}
- @SuppressWarnings("null")
static String toStringImpl(final KllSketch mine, final boolean withLevels, final boolean withData) {
final boolean doubleType = (mine.sketchType == DOUBLES_SKETCH);
final int k = mine.getK();
@@ -760,7 +759,6 @@ final class KllHelper {
* at the bottom. Only numLevels, the levels array and the items array are affected.
* @param mine the current sketch
*/
- @SuppressWarnings("null")
private static void addEmptyTopLevelToCompletelyFullSketch(final KllSketch mine) {
final int[] myCurLevelsArr = mine.getLevelsArray();
final int myCurNumLevels = mine.getNumLevels();
diff --git a/src/test/java/org/apache/datasketches/kll/KllDirectDoublesSketchTest.java b/src/test/java/org/apache/datasketches/kll/KllDirectDoublesSketchTest.java
index d43751e0..edc70109 100644
--- a/src/test/java/org/apache/datasketches/kll/KllDirectDoublesSketchTest.java
+++ b/src/test/java/org/apache/datasketches/kll/KllDirectDoublesSketchTest.java
@@ -614,7 +614,6 @@ public class KllDirectDoublesSketchTest {
}
@Test
- @SuppressWarnings("unused")
public void checkWritableWrapOfCompactForm() {
KllDoublesSketch sk = KllDoublesSketch.newHeapInstance(20);
for (int i = 1; i <= 21; i++ ) { sk.update(i); }
diff --git a/src/test/java/org/apache/datasketches/kll/KllDirectFloatsSketchTest.java b/src/test/java/org/apache/datasketches/kll/KllDirectFloatsSketchTest.java
index a159dc54..40d88dde 100644
--- a/src/test/java/org/apache/datasketches/kll/KllDirectFloatsSketchTest.java
+++ b/src/test/java/org/apache/datasketches/kll/KllDirectFloatsSketchTest.java
@@ -614,7 +614,6 @@ public class KllDirectFloatsSketchTest {
}
@Test
- @SuppressWarnings("unused")
public void checkWritableWrapOfCompactForm() {
KllFloatsSketch sk = KllFloatsSketch.newHeapInstance(20);
for (int i = 1; i <= 21; i++ ) { sk.update(i); }
diff --git a/src/test/java/org/apache/datasketches/kll/KllDoublesSketchTest.java b/src/test/java/org/apache/datasketches/kll/KllDoublesSketchTest.java
index 5684084a..b2e3eda1 100644
--- a/src/test/java/org/apache/datasketches/kll/KllDoublesSketchTest.java
+++ b/src/test/java/org/apache/datasketches/kll/KllDoublesSketchTest.java
@@ -32,7 +32,6 @@ import org.apache.datasketches.memory.Memory;
import org.apache.datasketches.memory.WritableMemory;
import org.testng.annotations.Test;
-@SuppressWarnings("javadoc")
public class KllDoublesSketchTest {
private static final double PMF_EPS_FOR_K_8 = 0.35; // PMF rank error (epsilon) for k=8
private static final double PMF_EPS_FOR_K_128 = 0.025; // PMF rank error (epsilon) for k=128
@@ -277,13 +276,11 @@ public class KllDoublesSketchTest {
assertEquals(sketch2.getMaxValue(), 1_000_000);
}
- @SuppressWarnings("unused")
@Test(expectedExceptions = SketchesArgumentException.class)
public void kTooSmall() {
KllDoublesSketch.newHeapInstance(KllSketch.DEFAULT_M - 1);
}
- @SuppressWarnings("unused")
@Test(expectedExceptions = SketchesArgumentException.class)
public void kTooLarge() {
KllDoublesSketch.newHeapInstance(KllSketch.MAX_K + 1);
diff --git a/src/test/java/org/apache/datasketches/kll/KllDoublesValidationTest.java b/src/test/java/org/apache/datasketches/kll/KllDoublesValidationTest.java
index bcc92cc1..bd0cfb0d 100644
--- a/src/test/java/org/apache/datasketches/kll/KllDoublesValidationTest.java
+++ b/src/test/java/org/apache/datasketches/kll/KllDoublesValidationTest.java
@@ -37,7 +37,7 @@ import org.testng.annotations.Test;
//These results are for the version that delays the roll up until the next value comes in.
//The @Test annotations have to be enabled to use this class and a section in KllDoublesHelper also
//needs to be enabled.
-@SuppressWarnings({ "javadoc", "unused" })
+@SuppressWarnings("unused")
public class KllDoublesValidationTest {
//Used only with manual running of checkTestResults(..)
diff --git a/src/test/java/org/apache/datasketches/kll/KllFloatsSketchTest.java b/src/test/java/org/apache/datasketches/kll/KllFloatsSketchTest.java
index a30e77f8..09bda87d 100644
--- a/src/test/java/org/apache/datasketches/kll/KllFloatsSketchTest.java
+++ b/src/test/java/org/apache/datasketches/kll/KllFloatsSketchTest.java
@@ -33,7 +33,6 @@ import org.apache.datasketches.memory.Memory;
import org.apache.datasketches.memory.WritableMemory;
import org.testng.annotations.Test;
-@SuppressWarnings("javadoc")
public class KllFloatsSketchTest {
private static final double PMF_EPS_FOR_K_8 = 0.35; // PMF rank error (epsilon) for k=8
private static final double PMF_EPS_FOR_K_128 = 0.025; // PMF rank error (epsilon) for k=128
@@ -278,13 +277,11 @@ public class KllFloatsSketchTest {
assertEquals(sketch2.getMaxValue(), 1_000_000F);
}
- @SuppressWarnings("unused")
@Test(expectedExceptions = SketchesArgumentException.class)
public void kTooSmall() {
KllFloatsSketch.newHeapInstance(KllSketch.DEFAULT_M - 1);
}
- @SuppressWarnings("unused")
@Test(expectedExceptions = SketchesArgumentException.class)
public void kTooLarge() {
KllFloatsSketch.newHeapInstance(KllSketch.MAX_K + 1);
diff --git a/src/test/java/org/apache/datasketches/kll/KllFloatsValidationTest.java b/src/test/java/org/apache/datasketches/kll/KllFloatsValidationTest.java
index 278d760c..cdb0f0ac 100644
--- a/src/test/java/org/apache/datasketches/kll/KllFloatsValidationTest.java
+++ b/src/test/java/org/apache/datasketches/kll/KllFloatsValidationTest.java
@@ -37,7 +37,7 @@ import org.testng.annotations.Test;
// These results are for the version that delays the roll up until the next value comes in.
// The @Test annotations have to be enabled to use this class and a section in KllFloatsHelper also
// needs to be enabled.
-@SuppressWarnings({ "javadoc", "unused" })
+@SuppressWarnings("unused")
public class KllFloatsValidationTest {
//Used only with manual running of checkTestResults(..)
diff --git a/src/test/java/org/apache/datasketches/kll/MiscDoublesTest.java b/src/test/java/org/apache/datasketches/kll/MiscDoublesTest.java
index e86488aa..656343cc 100644
--- a/src/test/java/org/apache/datasketches/kll/MiscDoublesTest.java
+++ b/src/test/java/org/apache/datasketches/kll/MiscDoublesTest.java
@@ -35,7 +35,6 @@ import org.testng.annotations.Test;
/**
* @author Lee Rhodes
*/
-@SuppressWarnings("javadoc")
public class MiscDoublesTest {
static final String LS = System.getProperty("line.separator");
private final MemoryRequestServer memReqSvr = new DefaultMemoryRequestServer();
diff --git a/src/test/java/org/apache/datasketches/kll/MiscFloatsTest.java b/src/test/java/org/apache/datasketches/kll/MiscFloatsTest.java
index 57cc244a..0b100e48 100644
--- a/src/test/java/org/apache/datasketches/kll/MiscFloatsTest.java
+++ b/src/test/java/org/apache/datasketches/kll/MiscFloatsTest.java
@@ -35,7 +35,6 @@ import org.testng.annotations.Test;
/**
* @author Lee Rhodes
*/
-@SuppressWarnings("javadoc")
public class MiscFloatsTest {
static final String LS = System.getProperty("line.separator");
private final MemoryRequestServer memReqSvr = new DefaultMemoryRequestServer();
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org