You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/15 11:31:13 UTC

[GitHub] [arrow] kszucs commented on a change in pull request #7192: ARROW-8815: [Dev][Release] Binary upload script should retry on unexpected bintray request error

kszucs commented on a change in pull request #7192:
URL: https://github.com/apache/arrow/pull/7192#discussion_r425740000



##########
File path: dev/release/binary-task.rb
##########
@@ -610,7 +610,7 @@ def download_url(url, output_path)
               $stderr.puts(build_download_error_message(url, response))
               return
             else
-              raise message

Review comment:
       @kou The original error was caused by undefined var `message`, but once I re-raised the exception the script was also exiting because certain kind of http error was not being handled so I worked around the problem by not re-raising just unconditionally retrying.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org