[jira] [Commented] (AIRFLOW-5898) alembic command crashes due to typing import path collision

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146617#comment-17146617 ] 

ASF subversion and git services commented on AIRFLOW-5898:
----------------------------------------------------------

Commit 3f8b5bf437ee148d62d8a265b1f85d8c4d800efe in airflow's branch refs/heads/v1-10-test from Qingping Hou
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=3f8b5bf ]

[AIRFLOW-5898] fix alembic crash due to typing import (#6547)

(cherry picked from commit 3a3730eaa5ff1b6ca25a510bd7fb6894f8965bc3)


> alembic command crashes due to typing import path collision
> -----------------------------------------------------------
>
>                 Key: AIRFLOW-5898
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5898
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: database
>    Affects Versions: 2.0.0
>            Reporter: QP Hou
>            Assignee: QP Hou
>            Priority: Trivial
>             Fix For: 2.0.0
>
>
> Running alemibc within airflow directory results in the following crash:
>  
> {code:java}
>   File "/Users/qph/Envs/airflow/lib/python3.7/site-packages/typing_extensions.py", line 17, in <module>
>     from typing import Generic, Callable, TypeVar, Tuple
> ImportError: cannot import name 'Generic' from 'typing'
> {code}
> This is due to typing.py within airlfow directory collides with the builtin typing module when a command runs inside airflow directory. Renaming it to `custom_typing.py` fixes the issue.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)