[GitHub] [skywalking-java] zhaoxiaojie0415 commented on a diff in pull request #467: Fix thrift plugin generate duplicate traceid

["zhaoxiaojie0415 (via GitHub)" <gi...@apache.org>]

zhaoxiaojie0415 commented on code in PR #467:
URL: https://github.com/apache/skywalking-java/pull/467#discussion_r1124358315


##########
test/plugin/scenarios/thrift-scenario/support-version.list:
##########
@@ -17,3 +17,4 @@
 0.12.0
 0.11.0
 0.10.0
+0.9.3

Review Comment:
   > @zhaoxiaojie0415 Is there any update about this?
   
   In thrift 0.9.3, it generate the interface with the param Generic erase which leads to test case fail. 
   Is it appropriate to write two versions of test cases?  （Actually 0.9.3 and 0.10.0 use same plugin code, but need to use different test cases）
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org