You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/03/29 18:03:53 UTC
[GitHub] [couchdb] wohali opened a new issue #3473: Normalise all config options so default.ini is 100% commented out
wohali opened a new issue #3473:
URL: https://github.com/apache/couchdb/issues/3473
The goal for `default.ini` and `local.ini` was always to have all values commented out.
It shouldn't be a hard effort to go through and make all of these values the correct defaults in the code.
Then, `default.ini` should just be **documentation** as to what the defaults are, so someone doesn't have to grep through a potentially unfriendly code base.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] wohali commented on issue #3473: Normalise all config options so default.ini is 100% commented out
Posted by GitBox <gi...@apache.org>.
wohali commented on issue #3473:
URL: https://github.com/apache/couchdb/issues/3473#issuecomment-867747381
Nice work @jiahuili430 @iilyak and others!
@chewbranca given this got closed, can you open a new issue for your comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] iilyak closed issue #3473: Normalise all config options so default.ini is 100% commented out
Posted by GitBox <gi...@apache.org>.
iilyak closed issue #3473:
URL: https://github.com/apache/couchdb/issues/3473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] chewbranca commented on issue #3473: Normalise all config options so default.ini is 100% commented out
Posted by GitBox <gi...@apache.org>.
chewbranca commented on issue #3473:
URL: https://github.com/apache/couchdb/issues/3473#issuecomment-867145131
If the aim is to get `default.ini` to be fully commented, then I think it would be prudent to delete `config:get/2` [1] which injects a default value in. If we're expecting to have the config options fully defined in code, then i don't think there is a scenario where having a config value lookup but not having a default valued defined in the code is appropriate.
[1] https://github.com/apache/couchdb-config/blob/main/src/config.erl#L156-L157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org