You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by vi...@apache.org on 2021/08/16 05:49:07 UTC
[superset] 17/34: chore: switch back tag name to popular from
highly-used (#16174)
This is an automated email from the ASF dual-hosted git repository.
villebro pushed a commit to branch 1.3
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 79ad7e8529266dd8da758ab70d7ba71acd35bdae
Author: Junlin Chen <ju...@preset.io>
AuthorDate: Tue Aug 10 17:23:14 2021 -1000
chore: switch back tag name to popular from highly-used (#16174)
* chore: switch back tag name to popular from highly-used
* new package lock
* new package lock with npm 7
* fix lint
* remove package changes
Co-authored-by: Beto Dealmeida <ro...@dealmeida.net>
(cherry picked from commit 9841c78967e64e6d4cec12c8db6fea8539dd32d8)
---
.../spec/javascripts/explore/components/VizTypeControl_spec.jsx | 2 +-
.../explore/components/controls/VizTypeControl/VizTypeGallery.tsx | 6 +-----
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/superset-frontend/spec/javascripts/explore/components/VizTypeControl_spec.jsx b/superset-frontend/spec/javascripts/explore/components/VizTypeControl_spec.jsx
index 02cbdac..c027fd0 100644
--- a/superset-frontend/spec/javascripts/explore/components/VizTypeControl_spec.jsx
+++ b/superset-frontend/spec/javascripts/explore/components/VizTypeControl_spec.jsx
@@ -50,7 +50,7 @@ describe('VizTypeControl', () => {
new ChartMetadata({
name: 'vis1',
thumbnail: '',
- tags: ['Highly-used'],
+ tags: ['Popular'],
}),
)
.registerValue(
diff --git a/superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx b/superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx
index bbbbeab..7f29334 100644
--- a/superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx
+++ b/superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx
@@ -121,11 +121,7 @@ const OTHER_CATEGORY = t('Other');
const ALL_CHARTS = t('All charts');
-const RECOMMENDED_TAGS = [
- t('Highly-used'),
- t('ECharts'),
- t('Advanced-Analytics'),
-];
+const RECOMMENDED_TAGS = [t('Popular'), t('ECharts'), t('Advanced-Analytics')];
export const VIZ_TYPE_CONTROL_TEST_ID = 'viz-type-control';