You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/26 06:45:11 UTC
[GitHub] [flink-kubernetes-operator] Aitozi opened a new pull request #25: [FLINK-26356] Use the common method to construct service name
Aitozi opened a new pull request #25:
URL: https://github.com/apache/flink-kubernetes-operator/pull/25
Use the common method to construct service name.
Besides, the `RestOptions.ADDRESS` is always generated at the server side we can not get it from the client config.
Since the flink-operator is always deployed with the flink job in the same cluster, we can directly use the `Servicename.Namespace` to talk to Flink job rest server.
I'am not sure whether need to remove the `config.getString(RestOptions.ADDRESS, xx)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a change in pull request #25: [FLINK-26356] Use the common method to construct service name
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #25:
URL: https://github.com/apache/flink-kubernetes-operator/pull/25#discussion_r815569944
##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##########
@@ -107,7 +108,11 @@ public void submitSessionCluster(FlinkDeployment deployment, Configuration conf)
final int port = config.getInteger(RestOptions.PORT);
final String host =
config.getString(
- RestOptions.ADDRESS, String.format("%s-rest.%s", clusterId, namespace));
+ RestOptions.ADDRESS,
Review comment:
Currently, the `RestOptions.ADDRESS` is always null in effective configuration. So we could simply always use the rest service name here. Right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] Aitozi commented on a change in pull request #25: [FLINK-26356] Use the common method to construct service name
Posted by GitBox <gi...@apache.org>.
Aitozi commented on a change in pull request #25:
URL: https://github.com/apache/flink-kubernetes-operator/pull/25#discussion_r815570545
##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##########
@@ -107,7 +108,11 @@ public void submitSessionCluster(FlinkDeployment deployment, Configuration conf)
final int port = config.getInteger(RestOptions.PORT);
final String host =
config.getString(
- RestOptions.ADDRESS, String.format("%s-rest.%s", clusterId, namespace));
+ RestOptions.ADDRESS,
Review comment:
Agree. I will follow your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] wangyang0918 merged pull request #25: [FLINK-26356] Use the common method to construct service name
Posted by GitBox <gi...@apache.org>.
wangyang0918 merged pull request #25:
URL: https://github.com/apache/flink-kubernetes-operator/pull/25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org