You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Grant Ingersoll (JIRA)" <ji...@apache.org> on 2008/05/28 20:25:45 UTC
[jira] Created: (LUCENE-1295) Make retrieveTerms(int docNum) public
in MoreLikeThis
Make retrieveTerms(int docNum) public in MoreLikeThis
-----------------------------------------------------
Key: LUCENE-1295
URL: https://issues.apache.org/jira/browse/LUCENE-1295
Project: Lucene - Java
Issue Type: Improvement
Components: contrib/*
Reporter: Grant Ingersoll
Assignee: Grant Ingersoll
Priority: Trivial
It would be useful if
{code}
private PriorityQueue retrieveTerms(int docNum) throws IOException {
{code}
were public, since it is similar in use to
{code}
public PriorityQueue retrieveTerms(Reader r) throws IOException {
{code}
It also seems useful to add
{code}
public String [] retrieveInterestingTerms(int docNum) throws IOException{
{code}
to mirror the one that works on Reader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1295) Make retrieveTerms(int docNum)
public in MoreLikeThis
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601340#action_12601340 ]
Otis Gospodnetic commented on LUCENE-1295:
------------------------------------------
I think cosmetic changes are OK if:
* they are not mixed with functional changes
* there are no patches for the cleaned-up class(es) in JIRA
In this case I see only a couple of MLT issues, all of which look like we can take care of them quickly, and then somebody can clean up a little if we feel like it. Anyhow...
> Make retrieveTerms(int docNum) public in MoreLikeThis
> -----------------------------------------------------
>
> Key: LUCENE-1295
> URL: https://issues.apache.org/jira/browse/LUCENE-1295
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Trivial
> Attachments: LUCENE-1295.patch
>
>
> It would be useful if
> {code}
> private PriorityQueue retrieveTerms(int docNum) throws IOException {
> {code}
> were public, since it is similar in use to
> {code}
> public PriorityQueue retrieveTerms(Reader r) throws IOException {
> {code}
> It also seems useful to add
> {code}
> public String [] retrieveInterestingTerms(int docNum) throws IOException{
> {code}
> to mirror the one that works on Reader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1295) Make retrieveTerms(int docNum)
public in MoreLikeThis
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600780#action_12600780 ]
Grant Ingersoll commented on LUCENE-1295:
-----------------------------------------
{quote}
Perque no.
{quote}
Huh?
{quote}
I see MLT is full of tabs, should you feel like fixing the formating.
{quote}
Yeah, I noticed that too, and it is quite egregious, but I thought we avoided formatting changes, but I am happy to make an exception here.
> Make retrieveTerms(int docNum) public in MoreLikeThis
> -----------------------------------------------------
>
> Key: LUCENE-1295
> URL: https://issues.apache.org/jira/browse/LUCENE-1295
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Trivial
> Attachments: LUCENE-1295.patch
>
>
> It would be useful if
> {code}
> private PriorityQueue retrieveTerms(int docNum) throws IOException {
> {code}
> were public, since it is similar in use to
> {code}
> public PriorityQueue retrieveTerms(Reader r) throws IOException {
> {code}
> It also seems useful to add
> {code}
> public String [] retrieveInterestingTerms(int docNum) throws IOException{
> {code}
> to mirror the one that works on Reader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1295) Make retrieveTerms(int docNum)
public in MoreLikeThis
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600679#action_12600679 ]
Otis Gospodnetic commented on LUCENE-1295:
------------------------------------------
Perque no. I see MLT is full of tabs, should you feel like fixing the formating.
> Make retrieveTerms(int docNum) public in MoreLikeThis
> -----------------------------------------------------
>
> Key: LUCENE-1295
> URL: https://issues.apache.org/jira/browse/LUCENE-1295
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Trivial
> Attachments: LUCENE-1295.patch
>
>
> It would be useful if
> {code}
> private PriorityQueue retrieveTerms(int docNum) throws IOException {
> {code}
> were public, since it is similar in use to
> {code}
> public PriorityQueue retrieveTerms(Reader r) throws IOException {
> {code}
> It also seems useful to add
> {code}
> public String [] retrieveInterestingTerms(int docNum) throws IOException{
> {code}
> to mirror the one that works on Reader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1295) Make retrieveTerms(int docNum) public
in MoreLikeThis
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grant Ingersoll updated LUCENE-1295:
------------------------------------
Attachment: LUCENE-1295.patch
I'll commit in a day or two.
> Make retrieveTerms(int docNum) public in MoreLikeThis
> -----------------------------------------------------
>
> Key: LUCENE-1295
> URL: https://issues.apache.org/jira/browse/LUCENE-1295
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Trivial
> Attachments: LUCENE-1295.patch
>
>
> It would be useful if
> {code}
> private PriorityQueue retrieveTerms(int docNum) throws IOException {
> {code}
> were public, since it is similar in use to
> {code}
> public PriorityQueue retrieveTerms(Reader r) throws IOException {
> {code}
> It also seems useful to add
> {code}
> public String [] retrieveInterestingTerms(int docNum) throws IOException{
> {code}
> to mirror the one that works on Reader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1295) Make retrieveTerms(int docNum)
public in MoreLikeThis
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grant Ingersoll resolved LUCENE-1295.
-------------------------------------
Resolution: Fixed
Lucene Fields: [New] (was: [Patch Available, New])
Committed revision 662413.
> Make retrieveTerms(int docNum) public in MoreLikeThis
> -----------------------------------------------------
>
> Key: LUCENE-1295
> URL: https://issues.apache.org/jira/browse/LUCENE-1295
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Trivial
> Attachments: LUCENE-1295.patch
>
>
> It would be useful if
> {code}
> private PriorityQueue retrieveTerms(int docNum) throws IOException {
> {code}
> were public, since it is similar in use to
> {code}
> public PriorityQueue retrieveTerms(Reader r) throws IOException {
> {code}
> It also seems useful to add
> {code}
> public String [] retrieveInterestingTerms(int docNum) throws IOException{
> {code}
> to mirror the one that works on Reader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org