You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "PrinceGallywix (via GitHub)" <gi...@apache.org> on 2023/02/16 16:11:17 UTC

[GitHub] [superset] PrinceGallywix opened a new issue, #23098: "Table object has no attribute 'engine'" error while uploading CSV into new ClickHouse table

PrinceGallywix opened a new issue, #23098:
URL: https://github.com/apache/superset/issues/23098

   It is not possible to upload a csv file to a new table in Clickhouse, but this is fine when the table already exists. 
   
   I assumed that the error was due to internal Clickhouse limitation: you can't create table without specifying an engine.
   I was hoping there was a way out by adding a core parameter to Clickhouse database: SET default_table_engine = 'MergeTree';
   With this setting it is possible to create a table without specifying an engine.
   
   But the error is the same :(
   
   I understand that Clickhouse support is experimental, uploading a CSV into ClickHouse is not supported, but are there any workarounds how to achive uploading a csv into this database using Superset? Especially when uploading into an existing table is possible.
   
   Let's assume that CSV uploading is only used with ClickHouse database in our organization and it's ok if a possible fix will break the compatibility with other databases :)
   
   #### How to reproduce the bug
   
   1. Add a ClickHouse connection
   2. Push "Upload csv" 
   3. Specify a ClickHouse connection and non-existent table
   4. See error
   
   ### Expected results
   
   CSV file has been uploaded
   
   ### Actual results
   
   Unable to upload CSV file <file name> to table <table name> in database <Connect name>. Error message: 'Table' object has no attribute 'engine'
   
   #### Screenshots
   ![image](https://user-images.githubusercontent.com/77333963/219412900-b62d55c5-dcaf-4e7e-adae-2d0a017f2565.png)
   
   
   ### Environment
   
   - python 3.9.2
   - superset 2.0.0 (also tried on 2.0.1)
   - clickhouse-connect 0.5.10
   - sqlalchemy 1.3.16
   - ClickHouse 23.2.1.1652
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] genzgd commented on issue #23098: "Table object has no attribute 'engine'" error while uploading CSV into new ClickHouse table

Posted by "genzgd (via GitHub)" <gi...@apache.org>.
genzgd commented on issue #23098:
URL: https://github.com/apache/superset/issues/23098#issuecomment-1498056609

   This is non-trivial to implement because of the way that Superset actually uploads CSVs.  There are plenty of ways to do this outside of Superset, but the current Superset implementation requires several SQLAlchemy features that are not implemented for ClickHouse and are not currently on the roadmap.  At some point it would be nice if Superset added an upload API in the EngineSpec that was not SQLAlchemy dependent.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] "Table object has no attribute 'engine'" error while uploading CSV into new ClickHouse table [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #23098:
URL: https://github.com/apache/superset/issues/23098#issuecomment-1962093367

   I'm not sure if this is still an issue in current versions of Superset (3.x), but it seems to have gone cold here. If it is still an issue (which it may well be), we can re-open this. Or feel free to open a new issue with updated context. We're no longer supporting Superset 2.x or prior, and it's been a while since this thread saw any activity, so I'm closing this as stale for now.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] "Table object has no attribute 'engine'" error while uploading CSV into new ClickHouse table [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #23098: "Table object has no attribute 'engine'" error while uploading CSV into new ClickHouse table
URL: https://github.com/apache/superset/issues/23098


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] lszyba1 commented on issue #23098: "Table object has no attribute 'engine'" error while uploading CSV into new ClickHouse table

Posted by "lszyba1 (via GitHub)" <gi...@apache.org>.
lszyba1 commented on issue #23098:
URL: https://github.com/apache/superset/issues/23098#issuecomment-1472352312

   Any workaround on this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org