You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/05/21 19:42:59 UTC
[GitHub] [kafka] andymg3 opened a new pull request, #12192: MINOR: Use parameterized logging in StandardAuthorizer and StandardAuthorizerData
andymg3 opened a new pull request, #12192:
URL: https://github.com/apache/kafka/pull/12192
This updates StandardAuthorizer and StandardAuthorizerData to use parameterized logging per the SLF4J recommendation (see https://www.slf4j.org/faq.html). This also removes a couple if statements that explicitly check if trace is enabled, but the logger should handle not publishing the message and not constructing the String if trace is not enabled.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #12192: MINOR: Use parameterized logging in StandardAuthorizer and StandardAuthorizerData
Posted by GitBox <gi...@apache.org>.
ijuma commented on PR #12192:
URL: https://github.com/apache/kafka/pull/12192#issuecomment-1133927100
Regarding the `trace` comment, we don't concat the final string, but we still have to pass the parameters. Seems ok in this case, but there are cases where even that is costly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji merged pull request #12192: MINOR: Use parameterized logging in StandardAuthorizer and StandardAuthorizerData
Posted by GitBox <gi...@apache.org>.
hachikuji merged PR #12192:
URL: https://github.com/apache/kafka/pull/12192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org