You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/24 15:09:45 UTC

[GitHub] [apisix] yxudong opened a new issue #4301: bug: skywalking not work when upsteam timeout

yxudong opened a new issue #4301:
URL: https://github.com/apache/apisix/issues/4301


   ### Issue description
   
   At presen, sw_tracer:finish()  will be called in body_filter_by_lua phase.
   But in some case, the http request will not execute body_filter_by_lua phase. so this function will not be called.
   
   Detail: https://github.com/apache/skywalking/issues/7004
   
   Is this function should be called in log_by_lua phase?
   
   ### What's the actual result? (including assertion message & call stack if applicable)
   
   The upsteam timeout case not work with skywalking plugin.
   
   ### What's the expected result?
   
   The upsteam timeout case could also be work with skywalking plugin.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] yxudong edited a comment on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
yxudong edited a comment on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847480765


   The specific case is here.
   
   >     location = /test {
   >         rewrite_by_lua_block {
   >             skywalking_tracer:start("upstream service")
   >         }
   > 
   >         proxy_pass http://test_upsteam;
   >         proxy_connect_timeout 1;
   >         proxy_send_timeout 1;
   >         proxy_read_timeout 1;
   > 
   >         body_filter_by_lua_block {
   >             if ngx.arg[2] then
   >                 skywalking_tracer:finish()
   >             end
   >         }
   > 
   >         log_by_lua_block {
   >             skywalking_tracer:prepareForReport()
   >         }
   >     }
   
   The proxy_read_timeout config is 1s.
   When http://test_upsteam reponse time more than that, nginx will has error log
   
   > upstream timed out (110: Connection timed out) while reading response header from upstream, xxxxxxxxxx
   
   In this case, the http request will not execute `body_filter_by_lua` phase, and `sw_tracer:finish` function is not be called also.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847536953


   > Response without body also causes this problem, like HEAD request's response.
   
   Thanks for sharing more cases. What is the recommended fix? Do we have to move this into the `log_by` with a recheck? We have to face an inaccurate end time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] yxudong edited a comment on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
yxudong edited a comment on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847480765


   The specific case is here.
   
   >     location = xxxxx/xxxxxx {
   >         rewrite_by_lua_block {
   >             skywalking_tracer:start("upstream service")
   >         }
   > 
   >         proxy_pass http://xxxxxxxxxx;
   >         proxy_connect_timeout 1;
   >         proxy_send_timeout 1;
   >         proxy_read_timeout 1;
   > 
   >         body_filter_by_lua_block {
   >             if ngx.arg[2] then
   >                 skywalking_tracer:finish()
   >             end
   >         }
   > 
   >         log_by_lua_block {
   >             skywalking_tracer:prepareForReport()
   >         }
   >     }
   
   The proxy_read_timeout config is 1s.
   When http://test_upsteam reponse time more than that, nginx will has error log
   
   > upstream timed out (110: Connection timed out) while reading response header from upstream, xxxxxxxxxx
   
   In this case, the http request will not execute body_filter_by_lua phase, and `sw_tracer:finish` function is not be called also.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-996378124


   @dmsolr Any update about this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] dmsolr commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
dmsolr commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-996393391


   I am sorry for pending long time. I am going to release a version before next week.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847842189


   Does `header_filter_by_lua` work for timeout?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] yxudong edited a comment on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
yxudong edited a comment on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847480765


   The specific case is here.
   
   >     location = /test {
   >         rewrite_by_lua_block {
   >             skywalking_tracer:start("upstream service")
   >         }
   > 
   >         proxy_pass http://test_upsteam;
   >         proxy_connect_timeout 1;
   >         proxy_send_timeout 1;
   >         proxy_read_timeout 1;
   > 
   >         body_filter_by_lua_block {
   >             if ngx.arg[2] then
   >                 skywalking_tracer:finish()
   >             end
   >         }
   > 
   >         log_by_lua_block {
   >             skywalking_tracer:prepareForReport()
   >         }
   >     }
   
   The proxy_read_timeout config is 1s.
   When http://test_upsteam reponse time more than that, nginx will has error log
   
   > upstream timed out (110: Connection timed out) while reading response header from upstream, xxxxxxxxxx
   
   In this case, the http request will not execute body_filter_by_lua phase, and `sw_tracer:finish` function is not be called also.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-1002896435


   Should APISIX upgrade the dependency for the next release?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander closed issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
spacewander closed issue #4301:
URL: https://github.com/apache/apisix/issues/4301


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847574701


   My opinion:
   1. normal response: keep the current behavior
   2. without response (the timed out case pointed by @yxudong): add `finish` call if we haven't called it yet
   3. header only response (`HEAD` request, 204 or 304 response): add `finish` call in the header filter phase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] yxudong commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
yxudong commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847839809


   Hi, everyone.
   
   It's seems that there is an easy solution to this problem.
   Just change `body_filter_by_lua` phase to `header_filter_by_lua` phase, because `body_filter_by_lua` may not be executed in some case, but `header_filter_by_lua` is always will be executed.
   At least, It's work in all the scenarios I can think of after my experiment.
   
   In addition, `sw_tracer:finish` should be called in header_filter_by_lua phase logically, because `header_filter_by_lua` phase is before `body_filter_by_lua` phase.
   
   Does it work this solution?
   Or Is there anything I missed.
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] dmsolr commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
dmsolr commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-1001105828


   Hi @yxudong , skywalking-nginx-lua v0.6.0 released. And it is available on luarocks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847112213


   Hi @apache/apisix-committers  SkyWalking community needs verification of whether this is the right description, and a correct way to fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847909777


   > In addition, sw_tracer:finish should be called in header_filter_by_lua phase logically, because header_filter_by_lua phase is before body_filter_by_lua phase.
   
   Calling the `finish` in header_filter_by_lua in a non-head-only response will result in a too-short trace span. Consider the server is serving a 1 GB file, the time when the response finish generating header is quite earlier than generating all the body.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-988548156


   ![image](https://user-images.githubusercontent.com/5441976/145162308-af4de142-2ccc-4581-b93d-1c6d15a01b3c.png)
   
   2 fixes are code related. It is 7 months since last release, if you feel you should, please run for it. If you do that, skywalking-kong 0.1.2 should be released with dependency upgrade.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] yxudong commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
yxudong commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847480765


   The specific case is here.
   
   > location = /test {
   >     rewrite_by_lua_block {
   >         skywalking_tracer:start("upstream service")
   >     }
   > 
   >     proxy_pass http://test_upsteam;
   >     proxy_connect_timeout 1;
   >     proxy_send_timeout 1;
   >     proxy_read_timeout 1;
   > 
   >     body_filter_by_lua_block {
   >         if ngx.arg[2] then
   >             skywalking_tracer:finish()
   >         end
   >     }
   > 
   >     log_by_lua_block {
   >         skywalking_tracer:prepareForReport()
   >     }
   > }
   
   The proxy_read_timeout config is 1s.
   When http://test_upsteam reponse time more than that, nginx will has error log
   
   > upstream timed out (110: Connection timed out) while reading response header from upstream, xxxxxxxxxx
   
   In this case, the http request will not execute body_filter_by_lua phase, and `sw_tracer:finish` function is not be called also.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] yxudong commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
yxudong commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847583358


   Ok, I'll try to work on a patch with this according to @spacewander 's opinion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] tokers commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
tokers commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847467718


   We may add a flag to check whether the `sw_tracer:finish` was called in the `body_by_lua_filter*` phase, if not, just calling it in `log_by_lua*` phase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-853027025


   https://github.com/apache/skywalking-nginx-lua/pull/85 merged. We will need skywalking's next release for APISIX fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847469523


   > We may add a flag to check whether the `sw_tracer:finish` was called in the `body_by_lua_filter*` phase, if not, just calling it in `log_by_lua*` phase.
   
   `log` method should not provide accurate endtime, as far as I know. If the timeout really could cause the issue, then I think we have to make a flag for the status.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847576227


   > My opinion:
   > 
   > 1. normal response: keep the current behavior
   > 2. without response (the timed out case pointed by @yxudong): add `finish` call if we haven't called it yet
   > 3. header only response (`HEAD` request, 204 or 304 response): add `finish` call in the header filter phase.
   
   @yxudong Would you work on a patch to SkyWalking nginx agent to do that? We need some code changes rather than only doc change.
   
   cc @dmsolr I think after this, we need to adjust Kong plugin. @spacewander we need to adopt this fix in APISIX too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] juzhiyuan commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-1003062429


   cc @shuaijinchao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] membphis commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-1003229400


   > Hi @yxudong , skywalking-nginx-lua v0.6.0 released. And it is available on luarocks
   
   @dmsolr I think you can submit the PR directly, it is very easy, here is an example: https://github.com/apache/apisix/pull/5971


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] yxudong commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
yxudong commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847912259


   > > In addition, sw_tracer:finish should be called in header_filter_by_lua phase logically, because header_filter_by_lua phase is before body_filter_by_lua phase.
   > 
   > Calling the `finish` in header_filter_by_lua in a non-head-only response will result in a too-short trace span. Consider the server is serving a 1 GB file, the time when the response finish generating header is quite earlier than generating all the body.
   
   Got it. Thank you for reply.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] membphis commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847444684


   Please provide a minimal reproducible case, then we can check it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] yxudong edited a comment on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
yxudong edited a comment on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847480765


   The specific case is here.
   
   >     location = /test {
   >         rewrite_by_lua_block {
   >             skywalking_tracer:start("upstream service")
   >         }
   > 
   >         proxy_pass http://test_upsteam;
   >         proxy_connect_timeout 1;
   >         proxy_send_timeout 1;
   >         proxy_read_timeout 1;
   > 
   >         body_filter_by_lua_block {
   >             if ngx.arg[2] then
   >                 skywalking_tracer:finish()
   >             end
   >         }
   > 
   >         log_by_lua_block {
   >             skywalking_tracer:prepareForReport()
   >         }
   >     }
   
   The proxy_read_timeout config is 1s.
   When http://test_upsteam reponse time more than that, nginx will has error log
   
   > upstream timed out (110: Connection timed out) while reading response header from upstream, xxxxxxxxxx
   
   In this case, the http request will not execute `body_filter_by_lua` phase, and `skywalking_tracer:finish()` function is not be called also.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-988544339


   @dmsolr 
   Maybe we can create a new release of skywalking-nginx-lua now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] yxudong commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
yxudong commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847880810


   If change `body_filter_by_lua` phase to `header_filter_by_lua` phase is too risk, I submitted a PR about this issue.
   
   https://github.com/apache/skywalking-nginx-lua/pull/85
   
   Add a flag to makesure the `Tracer:finish()` was called.
   Please check it.
   
   If it's no problem, I'd like to submitted a PR about Kong plugin and APISIX.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] yxudong commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
yxudong commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847844098


   Yes, I've already experimented about timeout case.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847493355


   Response without body also causes this problem, like HEAD request's response.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-847842853


   You should know, in other SkyWalking agents, there is a config to control collecting HTTP request and response bodies when necessary. It is better to keep `body_filter_by_lua` works in normal cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] yxudong closed issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
yxudong closed issue #4301:
URL: https://github.com/apache/apisix/issues/4301


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] wu-sheng closed issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #4301:
URL: https://github.com/apache/apisix/issues/4301


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] yxudong commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
yxudong commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-1002895526


   > Hi @yxudong , skywalking-nginx-lua v0.6.0 released. And it is available on luarocks
   
   Got it, Ths. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] dmsolr removed a comment on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
dmsolr removed a comment on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-996393391


   I am sorry for pending long time. I am going to release a version before next week.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] dmsolr commented on issue #4301: bug: skywalking not work when upsteam timeout

Posted by GitBox <gi...@apache.org>.
dmsolr commented on issue #4301:
URL: https://github.com/apache/apisix/issues/4301#issuecomment-996392753


   I am sorry for pending long time. I am going to release a version before next week.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org