[GitHub] [pinot] saurabhd336 commented on a diff in pull request #10715: Fix #10713 by considering tableConfig.indexingConfig.sortedColumns as…

["saurabhd336 (via GitHub)" <gi...@apache.org>]

saurabhd336 commented on code in PR #10715:
URL: https://github.com/apache/pinot/pull/10715#discussion_r1185722776


##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/IndexReaderFactory.java:
##########
@@ -45,6 +45,18 @@ R createIndexReader(SegmentDirectory.Reader segmentReader, FieldIndexConfigs fie
     protected abstract R createIndexReader(PinotDataBuffer dataBuffer, ColumnMetadata metadata, C indexConfig)
         throws IOException, IndexReaderConstraintException;
 
+    /**
+     * Sometimes the index configuration indicates that the index should be disabled but the reader actually contains
+     * a buffer for the index type.
+     *
+     * By default, the buffer has priority over the configuration, so in case we have a buffer we would create an index

Review Comment:
   Don't think this is the case. Originally, (https://github.com/apache/pinot/pull/10184/files#diff-271b081664e0c34f39b5ee282f33dc95bcc6cc45e94daa0aa89e8b6bc53213d6L82-L89)
   most index types would be config > buffer except a few (like dictionary).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org