You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/28 20:16:29 UTC
[GitHub] [spark] linehrr commented on issue #24461: [SPARK-27434][CORE] Fix
mem leak
linehrr commented on issue #24461: [SPARK-27434][CORE] Fix mem leak
URL: https://github.com/apache/spark/pull/24461#issuecomment-487411885
@srowen filesystem is shared that's true, but it's shared within a spark context, so if the context.close() is called, I think we can safely remove it. also, the static method FileSystem.get() is like a `getOrCreate`, so even if it's removed, other part of the code can get it again, the object will be recreated and cached(if I missed sth, please point me to the code where it could potentially get NPE after close, I can fix that).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org