You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/10/13 00:00:11 UTC
Review Request 26630: Fixed non-deterministic test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26630/
-----------------------------------------------------------
Review request for mesos and Timothy Chen.
Repository: mesos-git
Description
-------
The DockerContainerizerTest.ROOT_DOCKER_PortMapping test was doing a
Docker::kill on the container which should be finishing properly which
was causing the call to Docker::kill to fail when the container had
already finished properly and been cleaned up, thus causing the test
to fail.
Diffs
-----
src/tests/docker_containerizer_tests.cpp 67d60a885d65edbcbbf702bce83a54d1a5c0411f
Diff: https://reviews.apache.org/r/26630/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 26630: Fixed non-deterministic test.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26630/#review56364
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Oct. 12, 2014, 10 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26630/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2014, 10 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The DockerContainerizerTest.ROOT_DOCKER_PortMapping test was doing a
> Docker::kill on the container which should be finishing properly which
> was causing the call to Docker::kill to fail when the container had
> already finished properly and been cleaned up, thus causing the test
> to fail.
>
>
> Diffs
> -----
>
> src/tests/docker_containerizer_tests.cpp 67d60a885d65edbcbbf702bce83a54d1a5c0411f
>
> Diff: https://reviews.apache.org/r/26630/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 26630: Fixed non-deterministic test.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26630/#review56367
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26611, 26612, 26613, 26614, 26615, 26616, 26617, 26618, 26619, 26620, 26621, 26630]
All tests passed.
- Mesos ReviewBot
On Oct. 12, 2014, 10 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26630/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2014, 10 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The DockerContainerizerTest.ROOT_DOCKER_PortMapping test was doing a
> Docker::kill on the container which should be finishing properly which
> was causing the call to Docker::kill to fail when the container had
> already finished properly and been cleaned up, thus causing the test
> to fail.
>
>
> Diffs
> -----
>
> src/tests/docker_containerizer_tests.cpp 67d60a885d65edbcbbf702bce83a54d1a5c0411f
>
> Diff: https://reviews.apache.org/r/26630/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>