You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ignite.apache.org by "Andrey Mashenkov (Jira)" <ji...@apache.org> on 2019/12/12 16:02:00 UTC

[jira] [Updated] (IGNITE-11815) Get rid of GridTestUtils.retryAssert method.

     [ https://issues.apache.org/jira/browse/IGNITE-11815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrey Mashenkov updated IGNITE-11815:
--------------------------------------
    Priority: Minor  (was: Major)

> Get rid of GridTestUtils.retryAssert method.
> --------------------------------------------
>
>                 Key: IGNITE-11815
>                 URL: https://issues.apache.org/jira/browse/IGNITE-11815
>             Project: Ignite
>          Issue Type: Test
>            Reporter: Andrey Mashenkov
>            Assignee: Diana Iakovleva
>            Priority: Minor
>              Labels: MakeTeamcityGreenAgain, newbie
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> For now we have GridTestUtils.retryAssert() method which runs a closure 'n' times to check if some invariantes become ok, eventually.
> This method catch assertion error (this looks like a very bad idea) and can print them to log many times even if assertion is acceptable for the moment.
>  Also, it is possible to miss an assertion is not related to those ones that closure checks  (e.g. assertion error thrown from ignite internals).
> Let's replace retryAssert with GridTestUtils.waitForCondition() usage to make logs clearer and to avoid possible false positive results.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)