You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/06/10 07:25:56 UTC
[GitHub] [hive] lcspinter commented on a change in pull request #2368: HIVE-25222: Fix column name issue with commas
lcspinter commented on a change in pull request #2368:
URL: https://github.com/apache/hive/pull/2368#discussion_r648912392
##########
File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java
##########
@@ -201,8 +203,11 @@ public static Schema readSchema(Configuration conf) {
}
public static String[] selectedColumns(Configuration conf) {
- String[] readColumns = conf.getStrings(InputFormatConfig.SELECTED_COLUMNS);
- return readColumns != null && readColumns.length > 0 ? readColumns : null;
+ String readColumns = conf.get(InputFormatConfig.SELECTED_COLUMNS);
+ if (readColumns == null || readColumns.isEmpty()) {
+ return null;
+ }
Review comment:
nit: new line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org