[GitHub] [hudi] pratyakshsharma commented on a change in pull request #3312: [HUDI-648][RFC-20] Implement error log/table for Datasource/DeltaStreamer/WriteClient/Compaction writes

[GitBox <gi...@apache.org>]

pratyakshsharma commented on a change in pull request #3312:
URL: https://github.com/apache/hudi/pull/3312#discussion_r702302452



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -315,6 +315,17 @@ public void rollbackFailedBootstrap() {
    */
   public abstract O insert(I records, final String instantTime);
 
+  /**
+   * Inserts the given Error HoodieRecords, into the table. This API is intended to be used for normal writes.
+   * <p>
+   * This API is intended to be used to write wrong records.
+   *
+   * @param records Error HoodieRecords to insert
+   * @param instantTime Instant time of the commit
+   * @return Collection of WriteStatus to inspect errors and counts
+   */
+  public abstract O insertError(I records, final String instantTime);

Review comment:
       So this api inserts error records into a separate error table or the regular Hudi table? The java doc seems to be misleading. Can we mention into the error table?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org